From: Nick Porter <nick@portercomputing.co.uk>
Date: Wed, 1 Feb 2023 12:06:11 +0000 (+0000)
Subject: Ensure cache resources are freed before returning
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3a31f2435e1948d3fc14414a1c8481460033f270;p=thirdparty%2Ffreeradius-server.git

Ensure cache resources are freed before returning
---

diff --git a/src/modules/rlm_cache/rlm_cache.c b/src/modules/rlm_cache/rlm_cache.c
index d7aca03c54a..e13e6f03f16 100644
--- a/src/modules/rlm_cache/rlm_cache.c
+++ b/src/modules/rlm_cache/rlm_cache.c
@@ -883,14 +883,14 @@ xlat_action_t cache_xlat(TALLOC_CTX *ctx, fr_dcursor_t *out,
 
 	talloc_free(target);
 
+	cache_free(inst, &c);
+	cache_release(inst, request, &handle);
+
 	/*
 	 *	Check if we found a matching map
 	 */
 	if (!map) return XLAT_ACTION_FAIL;
 
-	cache_free(inst, &c);
-	cache_release(inst, request, &handle);
-
 	return XLAT_ACTION_DONE;
 }