From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Mon, 26 Aug 2013 19:15:21 +0000 (-0600)
Subject: Log %<sS (reply content length) as zero when object size is unknown.
X-Git-Tag: SQUID_3_5_0_1~117^2~51
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3a6460787f961056ffcc838693bdecb96c93a560;p=thirdparty%2Fsquid.git

Log %<sS (reply content length) as zero when object size is unknown.

For %<sS purposes, Squid computes reply content length as the difference
between "object size" and response headers. When headers were received but the
"object size" is not known (e.g., the promissed response body was never
received), that computation results in misleading negative numbers. We no
longer log them.
---

diff --git a/src/client_side.cc b/src/client_side.cc
index d60a16490e..0fdfdd2c3f 100644
--- a/src/client_side.cc
+++ b/src/client_side.cc
@@ -727,7 +727,7 @@ ClientHttpRequest::logRequest()
 
     debugs(33, 9, "clientLogRequest: http.code='" << al->http.code << "'");
 
-    if (loggingEntry() && loggingEntry()->mem_obj)
+    if (loggingEntry() && loggingEntry()->mem_obj && loggingEntry()->objectLen() >= 0)
         al->cache.objectSize = loggingEntry()->contentLen();
 
     al->cache.caddr.SetNoAddr();