From: James Jones <jejones3141@gmail.com>
Date: Thu, 28 Sep 2023 16:31:02 +0000 (-0500)
Subject: Add comment explaining annotation (CID #1414431) (#5184)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3a78ad86ef962751d2f1c694ce3eed5d23d9d0f4;p=thirdparty%2Ffreeradius-server.git

Add comment explaining annotation (CID #1414431) (#5184)
---

diff --git a/src/lib/server/pool.c b/src/lib/server/pool.c
index 6dd714d57a6..a987860c6a8 100644
--- a/src/lib/server/pool.c
+++ b/src/lib/server/pool.c
@@ -1061,6 +1061,12 @@ fr_pool_t *fr_pool_init(TALLOC_CTX *ctx,
 		goto error;
 	}
 
+	/*
+	 * 	Coverity notices that other uses of max_pending are protected with a mutex,
+	 * 	and thus thinks it should be locked/unlocked here...but coverity does not
+	 * 	consider that until this function returns a pointer to a pool, nobody can
+	 * 	use the pool, so there's no point to doing so.
+	 */
 	/* coverity[missing_lock] */
 	pool->pending_window = (pool->max_pending > 0) ? pool->max_pending : pool->max;