From: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed, 28 Jul 2004 23:39:12 +0000 (+0000)
Subject: chown/chgrp cleanup.
X-Git-Tag: v5.3.0~1030
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3a92cf062b102337fb2aada9570d6271b7f39ba6;p=thirdparty%2Fcoreutils.git

chown/chgrp cleanup.
---

diff --git a/ChangeLog b/ChangeLog
index 85622228f2..676ac03466 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,22 @@
 2004-07-28  Paul Eggert  <eggert@cs.ucla.edu>
 
+	* src/chgrp.c (parse_group): Require base 10 when parsing
+	groups as integers.
+	(main): int -> bool when appropriate.
+	* src/chown.c (main): Likewise.
+	* src/chown-core.c: Include inttostr.h.
+	(UINT_MAX_DECIMAL_DIGITS, uint_to_string): Remove.
+	(gid_to_name, uid_to_name): Use imaxtostr/umaxtostr
+	instead of uint_to_string).
+	(describe_change): Instead of an int flag, use a char *
+	auxiliary; this avoids the need for casts.
+	Assume free (NULL) works.
+	(change_file_owner): Return true/false, not 0/-1, since
+	we don't set errno.  All callers changed.
+	Use bool when appropriate.
+	(chown_files): Likewise.
+	* src/chown-core.h (chown_files): Likewise.
+
 	* tests/chown/basic: Test for proper handling of uids like
 	"010", which must be parsed as decimal.