From: Volker Lendecke <vl@samba.org>
Date: Tue, 22 May 2018 15:08:43 +0000 (+0200)
Subject: kdc: Fix CID 1435720 Unchecked return value
X-Git-Tag: ldb-1.4.0~67
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3aae048a43b1987eb2e60de988a8d4c180bfd6f6;p=thirdparty%2Fsamba.git

kdc: Fix CID 1435720 Unchecked return value

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source4/kdc/kdc-proxy.c b/source4/kdc/kdc-proxy.c
index 5072835fa19..0f84906338f 100644
--- a/source4/kdc/kdc-proxy.c
+++ b/source4/kdc/kdc-proxy.c
@@ -184,6 +184,7 @@ static void kdc_udp_proxy_resolve_done(struct composite_context *csubreq)
 	struct tevent_req *subreq;
 	struct tsocket_address *local_addr, *proxy_addr;
 	int ret;
+	bool ok;
 
 	status = resolve_name_recv(csubreq, state, &state->proxy.ip);
 	if (!NT_STATUS_IS_OK(status)) {
@@ -234,8 +235,15 @@ static void kdc_udp_proxy_resolve_done(struct composite_context *csubreq)
 		return;
 	}
 	tevent_req_set_callback(subreq, kdc_udp_proxy_recvfrom_done, req);
-	tevent_req_set_endtime(subreq, state->ev,
-			       timeval_current_ofs(state->kdc->proxy_timeout, 0));
+
+	ok = tevent_req_set_endtime(
+		subreq,
+		state->ev,
+		timeval_current_ofs(state->kdc->proxy_timeout, 0));
+	if (!ok) {
+		DBG_DEBUG("tevent_req_set_endtime failed\n");
+		return;
+	}
 
 	DEBUG(4,("kdc_udp_proxy: proxying request to %s[%s]\n",
 		 state->proxy.name.name, state->proxy.ip));