From: Jan Safranek <jsafrane@redhat.com>
Date: Wed, 24 Aug 2011 09:41:04 +0000 (+0200)
Subject: cgsnapshot: Fixed file descriptor leak when getting out of memory
X-Git-Tag: v0.38~53
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3ab4257b67d857c56be2021ef886691bc5b3c265;p=thirdparty%2Flibcgroup.git

cgsnapshot: Fixed file descriptor leak when getting out of memory

Close the iterator when cgroup_new_cgroup fails.

Signed-off-by: Jan Safranek <jsafrane@redhat.com>
Acked-by: Dhaval Giani <dhaval.giani@gmail.com>
---

diff --git a/src/tools/cgsnapshot.c b/src/tools/cgsnapshot.c
index 7359779e..a24dae70 100644
--- a/src/tools/cgsnapshot.c
+++ b/src/tools/cgsnapshot.c
@@ -486,7 +486,8 @@ static int display_controller_data(
 			if (group == NULL) {
 				printf("cannot create group '%s'\n",
 					cgroup_name);
-				return -1;
+				ret = ECGFAIL;
+				goto err;
 			}
 
 			ret = cgroup_get_cgroup(group);