From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 4 Oct 2022 14:47:38 +0000 (+0200)
Subject: virNodeDeviceCapPCIDefFormat: Use %u for unsigned values
X-Git-Tag: v8.10.0-rc1~257
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3ae376535a1c234aa41c74c642b942731c06777b;p=thirdparty%2Flibvirt.git

virNodeDeviceCapPCIDefFormat: Use %u for unsigned values

'bus', 'slot' and 'function' are unsigned int variables parsed as
unsigned int, but were formated as signed.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index 712d768e4a..b882fcfbe8 100644
--- a/src/conf/node_device_conf.c
+++ b/src/conf/node_device_conf.c
@@ -323,10 +323,10 @@ virNodeDeviceCapPCIDefFormat(virBuffer *buf,
         virBufferAsprintf(buf, "<class>0x%.6x</class>\n", data->pci_dev.klass);
     virBufferAsprintf(buf, "<domain>%d</domain>\n",
                       data->pci_dev.domain);
-    virBufferAsprintf(buf, "<bus>%d</bus>\n", data->pci_dev.bus);
-    virBufferAsprintf(buf, "<slot>%d</slot>\n",
+    virBufferAsprintf(buf, "<bus>%u</bus>\n", data->pci_dev.bus);
+    virBufferAsprintf(buf, "<slot>%u</slot>\n",
                       data->pci_dev.slot);
-    virBufferAsprintf(buf, "<function>%d</function>\n",
+    virBufferAsprintf(buf, "<function>%u</function>\n",
                       data->pci_dev.function);
     virBufferAsprintf(buf, "<product id='0x%04x'",
                       data->pci_dev.product);
diff --git a/tests/nodedevschemadata/pci_0000_00_02_0_header_type.xml b/tests/nodedevschemadata/pci_0000_00_02_0_header_type.xml
index 387fce7051..df620dc64f 100644
--- a/tests/nodedevschemadata/pci_0000_00_02_0_header_type.xml
+++ b/tests/nodedevschemadata/pci_0000_00_02_0_header_type.xml
@@ -4,7 +4,7 @@
   <capability type='pci'>
     <class>0xffffff</class>
     <domain>0</domain>
-    <bus>0</bus>
+    <bus>4294967295</bus>
     <slot>2</slot>
     <function>0</function>
     <product id='0x0416'>4th Gen Core Processor Integrated Graphics Controller</product>