From: James Jones <jejones3141@gmail.com>
Date: Sat, 9 Jul 2022 00:34:10 +0000 (-0500)
Subject: Annotate false positive in _raddict_report() (CID #1505146) (#4588)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3af3c36eb17fe29ad97c87cd775567f4a2f4337f;p=thirdparty%2Ffreeradius-server.git

Annotate false positive in _raddict_report() (CID #1505146) (#4588)

coverity doesn't know that if children == NULL, len will be
zero, so children won't be dereferenced.
---

diff --git a/src/bin/radict.c b/src/bin/radict.c
index d3079ab8a8b..0294f92a58c 100644
--- a/src/bin/radict.c
+++ b/src/bin/radict.c
@@ -218,6 +218,7 @@ static void _raddict_export(fr_dict_t const *dict, uint64_t *count, uintptr_t *l
 	children = dict_attr_children(da);
 	len = talloc_array_length(children);
 	for (i = 0; i < len; i++) {
+		/* coverity[dereference] */
 		for (p = children[i]; p; p = p->next) {
 			_raddict_export(dict, count, low, high, p, lvl + 1);
 		}