From: Prasad J Pandit Date: Thu, 7 Apr 2016 10:26:02 +0000 (+0530) Subject: net: mipsnet: check packet length against buffer X-Git-Tag: v2.7.0-rc0~157^2~29 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3af9187fc6caaf415ab9c0c6d92c9678f65cb17f;p=thirdparty%2Fqemu.git net: mipsnet: check packet length against buffer When receiving packets over MIPSnet network device, it uses receive buffer of size 1514 bytes. In case the controller accepts large(MTU) packets, it could lead to memory corruption. Add check to avoid it. Reported by: Oleksandr Bazhaniuk Signed-off-by: Prasad J Pandit Signed-off-by: Jason Wang --- diff --git a/hw/net/mipsnet.c b/hw/net/mipsnet.c index 740cd98ff1f..cf8b8236df8 100644 --- a/hw/net/mipsnet.c +++ b/hw/net/mipsnet.c @@ -83,6 +83,9 @@ static ssize_t mipsnet_receive(NetClientState *nc, const uint8_t *buf, size_t si if (!mipsnet_can_receive(nc)) return 0; + if (size >= sizeof(s->rx_buffer)) { + return 0; + } s->busy = 1; /* Just accept everything. */