From: Gustavo Sverzut Barbieri Date: Sat, 10 Dec 2011 11:21:03 +0000 (-0200) Subject: fix snprintf usage. X-Git-Tag: v1~55^2~22 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3b2099595b6b27cabbce60ac417d186c0a26d9d8;p=thirdparty%2Fkmod.git fix snprintf usage. snprintf() takes the full buffer size, including \0 and guarantees it will be there. --- diff --git a/libkmod/libkmod.c b/libkmod/libkmod.c index 46cabb58..2a4c0605 100644 --- a/libkmod/libkmod.c +++ b/libkmod/libkmod.c @@ -368,8 +368,7 @@ static int kmod_lookup_alias_from_alias_bin(struct kmod_ctx *ctx, } else{ char fn[PATH_MAX]; - fn[PATH_MAX - 1] = '\0'; - snprintf(fn, sizeof(fn) - 1, "%s/%s.bin", ctx->dirname, + snprintf(fn, sizeof(fn), "%s/%s.bin", ctx->dirname, index_files[index_number]); DBG(ctx, "file=%s name=%s\n", fn, name);