From: Rico Tzschichholz <ricotz@ubuntu.com>
Date: Sun, 18 Feb 2018 22:02:23 +0000 (+0100)
Subject: vala: Make SemanticAnalyzer.check_arguments() independent of context
X-Git-Tag: 0.39.92~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3b2e2d5a0847b903c7a4b73a41bba49acd5de8da;p=thirdparty%2Fvala.git

vala: Make SemanticAnalyzer.check_arguments() independent of context
---

diff --git a/vala/valamethodcall.vala b/vala/valamethodcall.vala
index 76f240382..415191ab6 100644
--- a/vala/valamethodcall.vala
+++ b/vala/valamethodcall.vala
@@ -371,6 +371,10 @@ public class Vala.MethodCall : Expression {
 		var args = get_argument_list ();
 		Iterator<Expression> arg_it = args.iterator ();
 		foreach (Parameter param in params) {
+			if (!param.check (context)) {
+				error = true;
+			}
+
 			if (param.ellipsis) {
 				break;
 			}
diff --git a/vala/valaobjectcreationexpression.vala b/vala/valaobjectcreationexpression.vala
index e203a1a2b..7a2d6fbf8 100644
--- a/vala/valaobjectcreationexpression.vala
+++ b/vala/valaobjectcreationexpression.vala
@@ -367,6 +367,10 @@ public class Vala.ObjectCreationExpression : Expression {
 			var args = get_argument_list ();
 			Iterator<Expression> arg_it = args.iterator ();
 			foreach (Parameter param in m.get_parameters ()) {
+				if (!param.check (context)) {
+					error = true;
+				}
+
 				if (param.ellipsis) {
 					break;
 				}
diff --git a/vala/valasemanticanalyzer.vala b/vala/valasemanticanalyzer.vala
index a0535ad42..ddf6f2859 100644
--- a/vala/valasemanticanalyzer.vala
+++ b/vala/valasemanticanalyzer.vala
@@ -408,10 +408,6 @@ public class Vala.SemanticAnalyzer : CodeVisitor {
 		bool ellipsis = false;
 		int i = 0;
 		foreach (Parameter param in params) {
-			if (!param.check (context)) {
-				return false;
-			}
-
 			if (param.ellipsis) {
 				ellipsis = true;
 				break;