From: Chris Rebert Date: Tue, 16 Feb 2016 11:52:30 +0000 (-0800) Subject: CONTRIBUTING: Document restriction regarding jQuery event alias methods X-Git-Tag: v4.0.0-alpha.3~237^2~12^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3b2f0523aab1906f018c19a741223f5c6fd98d4c;p=thirdparty%2Fbootstrap.git CONTRIBUTING: Document restriction regarding jQuery event alias methods Refs #19192 [ci skip] --- diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 122b1542a7..ab7b624c0e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -235,6 +235,7 @@ includes code changes) and under the terms of the - 2 spaces (no tabs) - strict mode - "Attractive" +- Don't use [jQuery event alias convenience methods](https://github.com/jquery/jquery/blob/master/src/event/alias.js) (such as `$().focus()`). Instead, use [`$().trigger(eventType, ...)`](http://api.jquery.com/trigger/) or [`$().on(eventType, ...)`](http://api.jquery.com/on/), depending on whether you're firing an event or listening for an event. (For example, `$().trigger('focus')` or `$().on('focus', function (event) { /* handle focus event */ })`) We do this to be compatible with custom builds of jQuery where the event aliases module has been excluded. ### Checking coding style