From: Jan Tulak <jtulak@redhat.com>
Date: Wed, 21 Jun 2017 22:14:29 +0000 (-0500)
Subject: metadump: warn about corruption if log is dirty
X-Git-Tag: v4.12.0-rc1~20
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3b3751ab0f9988504b39c161e6e00b462d09c130;p=thirdparty%2Fxfsprogs-dev.git

metadump: warn about corruption if log is dirty

Add a warning about possible corruption when exporting a dirty log, as
the log content does not agree with obfuscated metadata.

[sandeen: one more minor wording tweak]

Signed-off-by: Jan Tulak <jtulak@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/db/metadump.c b/db/metadump.c
index e83665891..4515f6826 100644
--- a/db/metadump.c
+++ b/db/metadump.c
@@ -2726,7 +2726,9 @@ copy_log(void)
 		/* keep the dirty log */
 		if (obfuscate)
 			print_warning(
-_("Filesystem log is dirty; image will contain unobfuscated metadata in log."));
+_("Warning: log recovery of an obfuscated metadata image can leak "
+"unobfuscated metadata and/or cause image corruption.  If possible, "
+"please mount the filesystem to clean the log, or disable obfuscation."));
 		break;
 	case -1:
 		/* log detection error */