From: Nick Porter <nick@portercomputing.co.uk>
Date: Wed, 22 Feb 2023 17:39:28 +0000 (+0000)
Subject: Align doxygen comments with function definitions
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3b44b24f2f79b4aa69134f9c83551819cda9cba0;p=thirdparty%2Ffreeradius-server.git

Align doxygen comments with function definitions
---

diff --git a/src/include/build.h b/src/include/build.h
index ce5c3c210d5..0cb8fce5a72 100644
--- a/src/include/build.h
+++ b/src/include/build.h
@@ -113,7 +113,7 @@ extern "C" {
  *
  * @param[in] _a	pointer to first structure.
  * @param[in] _b	pointer to second structure.
- * @param[in] _filed	within the structs to compare.
+ * @param[in] _field	within the structs to compare.
  * @return The result of the comparison.
  */
 #define CMP_RETURN(_a, _b, _field) \
diff --git a/src/lib/ldap/base.c b/src/lib/ldap/base.c
index ec049416457..17209ed9b0c 100644
--- a/src/lib/ldap/base.c
+++ b/src/lib/ldap/base.c
@@ -809,6 +809,7 @@ unlang_action_t fr_ldap_trunk_modify(rlm_rcode_t *p_result,
  *
  * Binds as the administrative user and attempts to modify an LDAP object.
  *
+ * @param[out] msgid		LDAP message ID.
  * @param[in] request		Current request.
  * @param[in,out] pconn		to use. May change as this function calls functions which auto re-connect.
  * @param[in] dn		of the object to modify.
@@ -921,7 +922,13 @@ fr_ldap_query_t *ldap_query_alloc(TALLOC_CTX *ctx, fr_ldap_request_type_t type)
 
 /** Allocate a new search object
  *
- * @param[in] ctx	to allocate query in.
+ * @param[in] ctx		to allocate query in.
+ * @param[in] base_dn		for the search.
+ * @param[in] scope		of the search.
+ * @param[in] filter		for the search
+ * @param[in] attrs		to request.
+ * @param[in] serverctrls	Search controls to pass to the server.  May be NULL.
+ * @param[in] clientctrls	Client controls.  May be NULL.
  */
 fr_ldap_query_t *fr_ldap_search_alloc(TALLOC_CTX *ctx,
 				      char const *base_dn, int scope, char const *filter, char const * const * attrs,
diff --git a/src/lib/ldap/referral.c b/src/lib/ldap/referral.c
index f235d144200..488b02f66ab 100644
--- a/src/lib/ldap/referral.c
+++ b/src/lib/ldap/referral.c
@@ -90,7 +90,9 @@ static void _ldap_referral_send(UNUSED fr_trunk_t *trunk, UNUSED fr_trunk_state_
  * We check all the possible referrals and look for one where there already
  * is an active trunk connection.
  *
- * @param query	whose result was one or more referral URLs
+ * @param t		Thread running the query.
+ * @param request	related to the query.
+ * @param query		whose result was one or more referral URLs.
  * @return
  * 	- 0 on success.
  * 	- < 0 on failure.
@@ -274,7 +276,9 @@ int fr_ldap_referral_follow(fr_ldap_thread_t *t, request_t *request, fr_ldap_que
  * new trunks are launched with watchers to send the query on the first
  * active trunk.
  *
- * @param query whose referrals are being chased
+ * @param t		Thread running the query.
+ * @param request	the query relates to.
+ * @param query		whose referrals are being chased.
  * @return
  *	- 0 on success.
  *	- < 0 on failure.
diff --git a/src/lib/unlang/xlat_alloc.c b/src/lib/unlang/xlat_alloc.c
index ac1d5207e97..03b05f218b7 100644
--- a/src/lib/unlang/xlat_alloc.c
+++ b/src/lib/unlang/xlat_alloc.c
@@ -201,6 +201,7 @@ xlat_exp_t *_xlat_exp_alloc(NDEBUG_LOCATION_ARGS TALLOC_CTX *ctx, xlat_type_t ty
  *
  * @param[in] node	to set fmt for.
  * @param[in] fmt	talloced buffer to set as the fmt string.
+ * @param[in] len	of fmt string.
  */
 void xlat_exp_set_name(xlat_exp_t *node, char const *fmt, size_t len)
 {
diff --git a/src/lib/unlang/xlat_eval.c b/src/lib/unlang/xlat_eval.c
index 446db673fb8..32978f65eb9 100644
--- a/src/lib/unlang/xlat_eval.c
+++ b/src/lib/unlang/xlat_eval.c
@@ -359,6 +359,7 @@ do { \
  * @param[in,out] list		value boxes provided as input.
  * 				List will be modified in accordance to rules
  * 				provided in the args array.
+ * @param[in] request		being processed.
  * @param[in] func		to call
  */
 static inline CC_HINT(always_inline)
diff --git a/src/lib/unlang/xlat_expr.c b/src/lib/unlang/xlat_expr.c
index f4fc2f58c05..a83a57534a8 100644
--- a/src/lib/unlang/xlat_expr.c
+++ b/src/lib/unlang/xlat_expr.c
@@ -629,6 +629,7 @@ static xlat_arg_parser_t const regex_op_xlat_args[] = {
 
 /** Perform a regular expressions comparison between two operands
  *
+ * @param[in] ctx		to allocate resulting box in.
  * @param[in] request		The current request.
  * @param[in] in		list of item or items
  * @param[in,out] preg		Pointer to pre-compiled or runtime-compiled
@@ -639,6 +640,7 @@ static xlat_arg_parser_t const regex_op_xlat_args[] = {
  *				The caller should only free the `regex_t *` if it
  *				compiled it, and the pointer has not been set to NULL
  *				when this function returns.
+ * @param[out] out		Where result is written.
  * @param[in] op		the operation to perform.
  * @return
  *	- -1 on failure.
diff --git a/src/lib/unlang/xlat_priv.h b/src/lib/unlang/xlat_priv.h
index 8c60c5d9732..0fd1303aa26 100644
--- a/src/lib/unlang/xlat_priv.h
+++ b/src/lib/unlang/xlat_priv.h
@@ -252,6 +252,7 @@ static inline void xlat_internal(xlat_t *xlat)
 /** Set a print routine for an xlat function.
  *
  * @param[in] xlat to set
+ * @param[in] func for printing
  */
 static inline void xlat_print_set(xlat_t *xlat, xlat_print_t func)
 {
@@ -262,6 +263,7 @@ static inline void xlat_print_set(xlat_t *xlat, xlat_print_t func)
 /** Set a resolve routine for an xlat function.
  *
  * @param[in] xlat to set
+ * @param[in] func to resolve xlat.
  */
 static inline void xlat_resolve_set(xlat_t *xlat, xlat_resolve_t func)
 {
@@ -272,6 +274,7 @@ static inline void xlat_resolve_set(xlat_t *xlat, xlat_resolve_t func)
 /** Set a resolve routine for an xlat function.
  *
  * @param[in] xlat to set
+ * @param[in] func to purify xlat
  */
 static inline void xlat_purify_set(xlat_t *xlat, xlat_purify_t func)
 {
diff --git a/src/lib/util/atexit.h b/src/lib/util/atexit.h
index b04b8f2e118..3101af82d9a 100644
--- a/src/lib/util/atexit.h
+++ b/src/lib/util/atexit.h
@@ -50,8 +50,8 @@ int _atexit_global(char const *file, int line, fr_atexit_t func, void const *uct
 
 /** Add a free function to the global free list
  *
- * @param[in] func to call.
- * @param[in] uctx to pass to func.
+ * @param[in] _func to call.
+ * @param[in] _uctx to pass to func.
  * @return
  *	- 0 on success.
  *      - -1 on failure.
diff --git a/src/lib/util/dbuff.h b/src/lib/util/dbuff.h
index 7d71ed998f3..b5c1770094a 100644
--- a/src/lib/util/dbuff.h
+++ b/src/lib/util/dbuff.h
@@ -544,7 +544,7 @@ static inline int _dbuff_thread_local_free(void *dbtl)
 
 /** Create a function local and thread local extensible dbuff
  *
- * @param[out] _dbuff_out	Where to write a pointer to the thread local dbuff
+ * @param[out] _out		Where to write a pointer to the thread local dbuff
  * @param[in] _init		Initial size for the dbuff buffer.
  * @param[in] _max		Maximum size of the dbuff buffer.
  */
@@ -1374,7 +1374,7 @@ static inline ssize_t _fr_dbuff_in_memcpy_dbuff(uint8_t **pos_p, fr_dbuff_t *out
 /** Copy exactly _inlen bytes into dbuff or marker returning if there's insufficient space
  * @copydetails fr_dbuff_in_memcpy
  */
-#define FR_DBUFF_IN_MEMCPY_RETURN(_out, _in, _inlen) FR_DBUFF_RETURN(fr_dbuff_in_memcpy, _out, _in, _inlen)
+#define FR_DBUFF_IN_MEMCPY_RETURN(_dbuff_or_marker, _in, _inlen) FR_DBUFF_RETURN(fr_dbuff_in_memcpy, _dbuff_or_marker, _in, _inlen)
 
 /** Internal function - do not call directly
  *
@@ -1577,7 +1577,7 @@ static inline ssize_t _fr_dbuff_in_double(uint8_t **pos_p, fr_dbuff_t *out, doub
  *
  * @copydetails fr_dbuff_in
  */
-#define FR_DBUFF_IN_RETURN(_out, _in) FR_DBUFF_RETURN(fr_dbuff_in, _out, _in)
+#define FR_DBUFF_IN_RETURN(_dbuff_or_marker, _in) FR_DBUFF_RETURN(fr_dbuff_in, _dbuff_or_marker, _in)
 
 /** Internal function - do not call directly
  * @private
@@ -1741,7 +1741,7 @@ static inline ssize_t _fr_dbuff_out_memcpy_dbuff(uint8_t **out_p, fr_dbuff_t *ou
  *
  * @copydetails fr_dbuff_out_memcpy
  */
-#define FR_DBUFF_OUT_MEMCPY_RETURN(_out, _in, _outlen) FR_DBUFF_RETURN(fr_dbuff_out_memcpy, _out, _in, _outlen)
+#define FR_DBUFF_OUT_MEMCPY_RETURN(_out, _dbuff_or_marker, _outlen) FR_DBUFF_RETURN(fr_dbuff_out_memcpy, _out, _dbuff_or_marker, _outlen)
 
 /** @cond */
 /** Define integer encoding functions
@@ -1794,7 +1794,7 @@ FR_DBUFF_OUT_DEF(int64)
  *
  * @copydetails fr_dbuff_out
  */
-#define FR_DBUFF_OUT_RETURN(_out, _in) FR_DBUFF_RETURN(fr_dbuff_out, _out, _in)
+#define FR_DBUFF_OUT_RETURN(_out, _dbuff_or_marker) FR_DBUFF_RETURN(fr_dbuff_out, _out, _dbuff_or_marker)
 
 /** Internal function - do not call directly
  * @private
diff --git a/src/lib/util/dcursor.h b/src/lib/util/dcursor.h
index 3c11121a925..d7c721843a2 100644
--- a/src/lib/util/dcursor.h
+++ b/src/lib/util/dcursor.h
@@ -137,6 +137,7 @@ static inline void *dcursor_current_set(fr_dcursor_t *cursor, void *current)
 /** Internal function to get the next item
  *
  * @param[in] cursor	to operate on.
+ * @param[in] iter	function.
  * @param[in] current	attribute.
  * @return
  *	- The next attribute.
@@ -643,10 +644,13 @@ static inline void fr_dcursor_free_list(fr_dcursor_t *cursor)
 /** Initialise a cursor with a custom iterator
  *
  * @param[in] _cursor		to initialise.
- * @param[in] _head		of item list.
+ * @param[in] _list		to iterate over.
  * @param[in] _iter		function.
  * @param[in] _peek		function.  If NULL _iter will be used for peeking.
  * @param[in] _iter_uctx	_iter function _uctx.
+ * @param[in] _insert		function.
+ * @param[in] _remove		function.
+ * @param[in] _mod_uctx		_insert and _remove function _uctx.
  * @return
  *	- NULL if _head does not point to any items, or the iterator matches no items
  *	  in the current list.
@@ -851,6 +855,7 @@ DIAG_OFF(unused-function)
  *				- #FR_DLIST_ENTRY
  *				- #FR_DLIST_TYPES
  *				- #FR_DLIST_FUNCS
+ * @param[in] _element_type	Type of element in the dlists.
  *
  * @note This macro should be used inside the header for the area of code
  * which will use type specific functions.
diff --git a/src/lib/util/decode.h b/src/lib/util/decode.h
index f296fc2c250..702cdf5a800 100644
--- a/src/lib/util/decode.h
+++ b/src/lib/util/decode.h
@@ -37,6 +37,7 @@ extern "C" {
  * @param[in] parent		of sub TLVs.
  * @param[in] data		to parse.
  * @param[in] data_len		of the data to parse
+ * @param[in] decode_ctx	ctx for decode function.
  * @return
  *	<= 0 on error
  *	bytes successfully decoded on success (<= data_len)
diff --git a/src/lib/util/dict_fixup.c b/src/lib/util/dict_fixup.c
index aaeaef6e08c..0f15010ce0d 100644
--- a/src/lib/util/dict_fixup.c
+++ b/src/lib/util/dict_fixup.c
@@ -119,6 +119,7 @@ static inline CC_HINT(always_inline) int dict_fixup_common(char const *filename,
  * @param[in] value		Value string.  This is kept as a string until we know
  *				what type we want to transform it into.
  * @param[in] value_len		Length of the value string.
+ * @param[in] parent		of this attribute.
  * @return
  *	- 0 on success.
  *	- -1 on out of memory.
@@ -381,6 +382,7 @@ static inline CC_HINT(always_inline) int dict_fixup_group_apply(UNUSED dict_fixu
  * @param[in] fctx		Holds current dictionary parsing information.
  * @param[in] filename		this fixup relates to.
  * @param[in] line		this fixup relates to.
+ * @param[in] parent		for the cloned attribute.
  * @param[in] da		The group dictionary attribute.
  * @param[in] ref		OID string representing what the group references.
  * @param[in] ref_len		Length of the reference string.
diff --git a/src/lib/util/dict_unknown.c b/src/lib/util/dict_unknown.c
index 0868bdba49f..73c35d7d263 100644
--- a/src/lib/util/dict_unknown.c
+++ b/src/lib/util/dict_unknown.c
@@ -376,6 +376,7 @@ fr_dict_attr_t	*fr_dict_unknown_attr_afrom_da(TALLOC_CTX *ctx, fr_dict_attr_t co
  *	and will be use the unknown da as its talloc parent.
  *
  * @param[in] ctx		to alloc new attribute in.
+ * @param[out] err		Where to write error codes.
  * @param[out] out		Where to write the head of the chain unknown
  *				dictionary attributes.
  * @param[in] parent		Attribute to use as the root for resolving OIDs in.
diff --git a/src/lib/util/dict_util.c b/src/lib/util/dict_util.c
index bfc35edf6e3..e165b417ff8 100644
--- a/src/lib/util/dict_util.c
+++ b/src/lib/util/dict_util.c
@@ -2325,6 +2325,7 @@ fr_dict_attr_t const *fr_dict_vendor_da_by_num(fr_dict_attr_t const *vendor_root
  * @param[out] err	Where to write error codes.  Any error
  *			other than FR_DICT_ATTR_NOTFOUND will
  *			prevent resolution from continuing.
+ * @param[out] out	Where to write resolved DA.
  * @param[in] parent	The dictionary root or other attribute to search from.
  * @param[in] in	Contains the string to resolve.
  * @param[in] tt	Terminal sequences to use to determine the portion
@@ -3210,6 +3211,7 @@ int dict_dependent_add(fr_dict_t *dict, char const *dependent)
  * be bound to the lifetime of an additional object.
  *
  * @param[in] dict	to increase the reference count for.
+ * @param[in] dependent	requesting the loading of the dictionary.
  * @return
  *	- 0 on success.
  *	- -1 on error.
@@ -3626,6 +3628,7 @@ int fr_dict_attr_autoload(fr_dict_attr_autoload_t const *to_load)
 /** Process a dict_autoload element to load a protocol
  *
  * @param[in] to_load	dictionary definition.
+ * @param[in] dependent	that is loading this dictionary.
  * @return
  *	- 0 on success.
  *	- -1 on failure.
@@ -3661,6 +3664,7 @@ int _fr_dict_autoload(fr_dict_autoload_t const *to_load, char const *dependent)
 /** Decrement the reference count on a previously loaded dictionary
  *
  * @param[in] to_free	previously loaded dictionary to free.
+ * @param[in] dependent	that originally allocated this dictionary
  */
 int _fr_dict_autofree(fr_dict_autoload_t const *to_free, char const *dependent)
 {
diff --git a/src/lib/util/dns.c b/src/lib/util/dns.c
index a2662b5843e..7b62ddca071 100644
--- a/src/lib/util/dns.c
+++ b/src/lib/util/dns.c
@@ -595,6 +595,7 @@ static bool dns_label_compress(uint8_t const *packet, uint8_t const *start, uint
  * @param[in] dbuff	Buffer where labels are written
  * @param[in] compression Whether or not to do DNS label compression.
  * @param[in] value	to encode.
+ * @param[in] lb	label tracking data structure.
  * @return
  *	- >0 the number of bytes written to the dbuff
  *	- 0 could not encode anything, an error has occurred.
diff --git a/src/lib/util/encode.c b/src/lib/util/encode.c
index 822b48cdf10..9f7fe1df63c 100644
--- a/src/lib/util/encode.c
+++ b/src/lib/util/encode.c
@@ -33,6 +33,7 @@
  * @param[in] depth		in the da_stack.
  * @param[in,out] cursor	Current attribute we're encoding.
  * @param[in] encode_ctx	Containing DHCPv4 dictionary.
+ * @param[in] encode_value	Function to perform encoding of a single value.
  * @return
  *	- >0 length of data encoded.
  *	- 0 if we ran out of space.
diff --git a/src/lib/util/event.h b/src/lib/util/event.h
index 05b39abbb2f..91f2e129421 100644
--- a/src/lib/util/event.h
+++ b/src/lib/util/event.h
@@ -112,6 +112,7 @@ typedef struct {
 /** Called when a timer event fires
  *
  * @param[in] now	The current time.
+ * @param[in] el	Event list the timer event was inserted into.
  * @param[in] uctx	User ctx passed to #fr_event_timer_in or #fr_event_timer_at.
  */
 typedef	void (*fr_event_timer_cb_t)(fr_event_list_t *el, fr_time_t now, void *uctx);
diff --git a/src/lib/util/pair.h b/src/lib/util/pair.h
index 5d6ffc3edd9..0b3e71df8b1 100644
--- a/src/lib/util/pair.h
+++ b/src/lib/util/pair.h
@@ -537,10 +537,10 @@ int		fr_pair_unflatten(fr_pair_t *vp)  CC_HINT(nonnull);
  *
  * @note This is the only way to use a dcursor in non-const mode with fr_pair_list_t.
  *
- * @param[out] cursor	to initialise.
- * @param[in] list	to iterate over.
- * @param[in] iter	Iterator to use when filtering pairs.
- * @param[in] uctx	To pass to iterator.
+ * @param[out] _cursor	to initialise.
+ * @param[in] _list	to iterate over.
+ * @param[in] _iter	Iterator to use when filtering pairs.
+ * @param[in] _uctx	To pass to iterator.
  * @return
  *	- NULL if src does not point to any items.
  *	- The first pair in the list.
@@ -561,8 +561,8 @@ fr_pair_t	*_fr_pair_dcursor_iter_init(fr_dcursor_t *cursor, fr_pair_list_t const
  *
  * @note This is the only way to use a dcursor in non-const mode with fr_pair_list_t.
  *
- * @param[out] cursor	to initialise.
- * @param[in] list	to iterate over.
+ * @param[out] _cursor	to initialise.
+ * @param[in] _list	to iterate over.
  * @return
  *	- NULL if src does not point to any items.
  *	- The first pair in the list.
@@ -576,9 +576,9 @@ fr_pair_t	*_fr_pair_dcursor_init(fr_dcursor_t *cursor, fr_pair_list_t const *lis
 
 /** Initialise a cursor that will return only attributes matching the specified #fr_dict_attr_t
  *
- * @param[in] cursor	to initialise.
- * @param[in] list	to iterate over.
- * @param[in] da	to search for.
+ * @param[in] _cursor	to initialise.
+ * @param[in] _list	to iterate over.
+ * @param[in] _da	to search for.
  * @return
  *	- The first matching pair.
  *	- NULL if no pairs match.
@@ -594,9 +594,9 @@ fr_pair_t	*_fr_pair_dcursor_by_da_init(fr_dcursor_t *cursor,
 
 /** Initialise a cursor that will return only attributes descended from the specified #fr_dict_attr_t
  *
- * @param[in] cursor	to initialise.
- * @param[in] list	to iterate over.
- * @param[in] da	who's decentness to search for.
+ * @param[in] _cursor	to initialise.
+ * @param[in] _list	to iterate over.
+ * @param[in] _da	who's decentness to search for.
  * @return
  *	- The first matching pair.
  *	- NULL if no pairs match.
diff --git a/src/lib/util/rb.h b/src/lib/util/rb.h
index 6027492f383..8581fb1d46f 100644
--- a/src/lib/util/rb.h
+++ b/src/lib/util/rb.h
@@ -107,7 +107,6 @@ struct fr_rb_tree_s {
  *				If ctx is freed, tree will free any nodes, calling the
  *				free function if set.
  * @param[in] _type		of item being stored in the tree, e.g. fr_value_box_t.
- * @param[in] _field		Containing the #fr_rb_node_t within item being stored.
  * @param[in] _data_cmp		Callback to compare node data.
  * @param[in] _data_free	Optional function used to free data if tree nodes are
  *				deleted or replaced.
@@ -196,7 +195,6 @@ int _fr_rb_init(fr_rb_tree_t *tree, TALLOC_CTX *node_ctx,
  *				If ctx is freed, tree will free any nodes, calling the
  *				free function if set.
  * @param[in] _type		of item being stored in the tree, e.g. fr_value_box_t.
- * @param[in] _field		Containing the #fr_rb_node_t within item being stored.
  * @param[in] _data_cmp		Callback to compare node data.
  * @param[in] _data_free	Optional function used to free data if tree nodes are
  *				deleted or replaced.
diff --git a/src/lib/util/table.c b/src/lib/util/table.c
index 7a9152568f6..c9bbf86f4f4 100644
--- a/src/lib/util/table.c
+++ b/src/lib/util/table.c
@@ -35,6 +35,7 @@ RCSID("$Id$")
 /** Brute force search a sorted or ordered ptr table, assuming the pointers are strings
  *
  * @param[in] table		to search in.
+ * @param[in] table_len		Number of elements in the table.
  * @param[in] str_val		to compare against the ptr field.
  * @param[in] def		default value.
  */
diff --git a/src/lib/util/time.h b/src/lib/util/time.h
index 7e42717d95d..7baaab5ac74 100644
--- a/src/lib/util/time.h
+++ b/src/lib/util/time.h
@@ -647,7 +647,7 @@ static inline int64_t fr_time_delta_to_sec(fr_time_delta_t delta)
 
 /** Convert a delta to a timeval
  *
- * @param[in] delta	in nanoseconds.
+ * @param[in] _delta	in nanoseconds.
  */
 #define fr_time_delta_to_timeval(_delta) \
 (struct timeval){ \
@@ -657,7 +657,7 @@ static inline int64_t fr_time_delta_to_sec(fr_time_delta_t delta)
 
 /** Convert a delta to a timespec
  *
- * @param[in] delta	in nanoseconds.
+ * @param[in] _delta	in nanoseconds.
  */
 #define fr_time_delta_to_timespec(_delta)\
 (struct timespec){ \
diff --git a/src/lib/util/trie.c b/src/lib/util/trie.c
index ff479c31041..12e72867245 100644
--- a/src/lib/util/trie.c
+++ b/src/lib/util/trie.c
@@ -730,8 +730,9 @@ typedef struct {
 
 /** Allocate a trie
  *
- * @param ctx The talloc ctx
- * @param get_key The "get key from object" function.
+ * @param ctx		The talloc ctx.
+ * @param get_key	The "get key from object" function.
+ * @param free_data	Callback to free data.
  * @return
  *	- NULL on error
  *	- fr_trie_node_t on success
diff --git a/src/lib/util/value.c b/src/lib/util/value.c
index 5b79cf1d702..47bc410dca5 100644
--- a/src/lib/util/value.c
+++ b/src/lib/util/value.c
@@ -4481,7 +4481,9 @@ void fr_value_box_increment(fr_value_box_t *vb)
  *
  * @param[out] dst		where to write parsed value.
  * @param[in] dst_type		type of integer to convert string to.
+ * @param[in] dst_enumv		Enumeration values.
  * @param[in] in		String to convert to integer.
+ * @param[in] rules		for parsing string.
  * @param[in] tainted		Whether the value came from a trusted source.
  * @return
  *	- >= 0 on success (number of bytes parsed).
diff --git a/src/listen/ldap_sync/active_directory.c b/src/listen/ldap_sync/active_directory.c
index 87505c36ba7..f5cad5f95b7 100644
--- a/src/listen/ldap_sync/active_directory.c
+++ b/src/listen/ldap_sync/active_directory.c
@@ -163,6 +163,7 @@ int active_directory_sync_state_init(fr_ldap_connection_t *conn, size_t sync_no,
  *
  * @param[in] sync	message was associated with.
  * @param[in] msg	containing an entry to process.
+ * @param[in] ctrls	unused LDAP controls
  * @return
  *	- 0 on success.
  *	- -1 on failure.
diff --git a/src/listen/ldap_sync/proto_ldap_sync_ldap.c b/src/listen/ldap_sync/proto_ldap_sync_ldap.c
index acf1730a648..abd3f344464 100644
--- a/src/listen/ldap_sync/proto_ldap_sync_ldap.c
+++ b/src/listen/ldap_sync/proto_ldap_sync_ldap.c
@@ -170,6 +170,8 @@ static int sync_state_free(sync_state_t *sync)
  *
  * @param[in] ctx	to allocate the sync state in.
  * @param[in] conn	which the sync will run on.
+ * @param[in] inst	module instance for the sync.
+ * @param[in] sync_no	number of the sync in the array of configs.
  * @param[in] config	for the sync.
  * @return new sync state.
  */
diff --git a/src/modules/rlm_detail/rlm_detail.c b/src/modules/rlm_detail/rlm_detail.c
index a70189ac803..7b6a7b5a4cd 100644
--- a/src/modules/rlm_detail/rlm_detail.c
+++ b/src/modules/rlm_detail/rlm_detail.c
@@ -228,6 +228,7 @@ static void detail_fr_pair_fprint(TALLOC_CTX *ctx, FILE *out, fr_pair_t const *s
  * @param[in] inst Instance of rlm_detail.
  * @param[in] request The current request.
  * @param[in] packet associated with the request (request, reply...).
+ * @param[in] list of pairs to write.
  * @param[in] compat Write out entry in compatibility mode.
  */
 static int detail_write(FILE *out, rlm_detail_t const *inst, request_t *request,
diff --git a/src/modules/rlm_ldap/user.c b/src/modules/rlm_ldap/user.c
index 1a15723bfc6..603884291c6 100644
--- a/src/modules/rlm_ldap/user.c
+++ b/src/modules/rlm_ldap/user.c
@@ -50,6 +50,7 @@ USES_APPLE_DEPRECATED_API
  * @param[in] attrs Additional attributes to retrieve, may be NULL.
  * @param[in] force Query even if the User-DN already exists.
  * @param[out] result Where to write the result, may be NULL in which case result is discarded.
+ * @param[out] handle on which the LDAP query is run.
  * @param[out] rcode The status of the operation, one of the RLM_MODULE_* codes.
  * @return The user's DN or NULL on error.
  */
diff --git a/src/modules/rlm_lua/lua.c b/src/modules/rlm_lua/lua.c
index b8128758fbf..8da536c15ba 100644
--- a/src/modules/rlm_lua/lua.c
+++ b/src/modules/rlm_lua/lua.c
@@ -186,6 +186,7 @@ DIAG_ON(type-limits)
  * Convert Lua values back to fr_pair_ts. How the Lua value is converted is dependent
  * on the type of the DA.
  *
+ * @param[in] ctx	To allocate new fr_pair_t in.
  * @param[out] out	Where to write a pointer to the new fr_pair_t.
  * @param[in] inst	the current instance.
  * @param[in] request	the current request.