From: Ján Tomko <jtomko@redhat.com>
Date: Thu, 21 Feb 2019 15:22:22 +0000 (+0100)
Subject: qemu: fix memory leak in qemuBuildDiskDeviceStr
X-Git-Tag: v5.1.0-rc1~20
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3b4819802b9168b8cb3333a517ed808e521a7531;p=thirdparty%2Flibvirt.git

qemu: fix memory leak in qemuBuildDiskDeviceStr

Commit a1dce962 added the allocated scsiVPDDeviceId without freeing it.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index f511193fca..74f34af292 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -1890,7 +1890,7 @@ qemuBuildDiskDeviceStr(const virDomainDef *def,
     const char *bus = virDomainDiskQEMUBusTypeToString(disk->bus);
     const char *contAlias;
     char *backendAlias = NULL;
-    char *scsiVPDDeviceId = NULL;
+    VIR_AUTOFREE(char *) scsiVPDDeviceId = NULL;
     int controllerModel;
 
     if (qemuCheckDiskConfig(disk, qemuCaps) < 0)