From: Ethan Nelson-Moore Date: Sat, 24 Jan 2026 03:22:43 +0000 (-0800) Subject: net: usb: sr9700: replace magic numbers with register bit macros X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3b721117fe150fc4d78628d78627f9b446930b44;p=thirdparty%2Fkernel%2Flinux.git net: usb: sr9700: replace magic numbers with register bit macros The first byte of the Rx frame is a copy of the Rx status register, so 0x40 corresponds to RSR_MF (meaning the frame is multicast). Replace 0x40 with RSR_MF for clarity. (All other bits of the RSR indicate errors. The fact that the driver ignores these errors will be fixed by a later patch.) The first byte of the status URB is a copy of the NSR, so 0x40 corresponds to NSR_LINKST. Replace 0x40 with NSR_LINKST for clarity. Signed-off-by: Ethan Nelson-Moore Reviewed-by: Peter Korsgaard Link: https://patch.msgid.link/20260124032248.26807-1-enelsonmoore@gmail.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c index dba8615ca854..49764bcf0912 100644 --- a/drivers/net/usb/sr9700.c +++ b/drivers/net/usb/sr9700.c @@ -366,7 +366,7 @@ static int sr9700_rx_fixup(struct usbnet *dev, struct sk_buff *skb) /* one skb may contains multiple packets */ while (skb->len > SR_RX_OVERHEAD) { - if (skb->data[0] != 0x40) + if (skb->data[0] != RSR_MF) return 0; /* ignore the CRC length */ @@ -455,7 +455,7 @@ static void sr9700_status(struct usbnet *dev, struct urb *urb) buf = urb->transfer_buffer; - link = !!(buf[0] & 0x40); + link = !!(buf[0] & NSR_LINKST); sr9700_handle_link_change(dev->net, link); }