From: Eric Biggers Date: Tue, 21 Aug 2018 17:59:37 +0000 (-0700) Subject: e2fsck: allow verity files to have initialized blocks past i_size X-Git-Tag: v1.44.5~36 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3baafde6a8ae;p=thirdparty%2Fe2fsprogs.git e2fsck: allow verity files to have initialized blocks past i_size Since ext4 verity is going to be an RO_COMPAT feature rather than an INCOMPAT one, the on-disk i_size of verity inodes needs to be the data size rather than the full size. Consequently, verity inodes will have initialized blocks past i_size, containing the Merkle tree and other verity metadata. So e2fsck must not fix the i_size of such inodes as it normally would. Signed-off-by: Eric Biggers Signed-off-by: Theodore Ts'o --- diff --git a/e2fsck/pass1.c b/e2fsck/pass1.c index ce43821dc..8abf0c33a 100644 --- a/e2fsck/pass1.c +++ b/e2fsck/pass1.c @@ -3447,7 +3447,8 @@ static void check_blocks(e2fsck_t ctx, struct problem_context *pctx, size = EXT2_I_SIZE(inode); if ((pb.last_init_lblock >= 0) && /* Do not allow initialized allocated blocks past i_size*/ - (size < (__u64)pb.last_init_lblock * fs->blocksize)) + (size < (__u64)pb.last_init_lblock * fs->blocksize) && + !(inode->i_flags & EXT4_VERITY_FL)) bad_size = 3; else if (!(extent_fs && (inode->i_flags & EXT4_EXTENTS_FL)) && size > ext2_max_sizes[fs->super->s_log_block_size])