From: Pavel Filipenský <pfilipen@redhat.com>
Date: Mon, 23 May 2022 10:57:42 +0000 (+0200)
Subject: s3:lib: Fix use_after_free: Using freed pointer "p"
X-Git-Tag: talloc-2.3.4~84
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3bb6b05781fa79de697d859d18c4fc252831fdef;p=thirdparty%2Fsamba.git

s3:lib: Fix use_after_free: Using freed pointer "p"

Found by covscan.

Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/lib/netapi/examples/common.c b/source3/lib/netapi/examples/common.c
index 66b2bd3b6d0..72d7150b4ea 100644
--- a/source3/lib/netapi/examples/common.c
+++ b/source3/lib/netapi/examples/common.c
@@ -140,6 +140,7 @@ char *netapi_read_file(const char *filename, uint32_t *psize)
 		tmp = realloc(p, sizeof(char) * newbufsize);
 		if (tmp == NULL) {
 			free(p);
+			p = NULL;
 			goto fail;
 		}
 		p = tmp;