From: Damien Miller <djm@mindrot.org>
Date: Mon, 24 Feb 2025 06:27:50 +0000 (+1100)
Subject: Try to fix github tcmalloc target failure
X-Git-Tag: V_10_0_P1~64
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3bc6de98c830bd5207f6c371ba69c5874f06305b;p=thirdparty%2Fopenssh-portable.git

Try to fix github tcmalloc target failure

tcmalloc may, depending on the stacktrace generator it uses, create
pipe(2) fds during shared library initialisation. These will later
get clobbered by ssh/sshd calling closefrom() and chaos will ensue.
Tell tcmalloc to use an unwinder that doesn't pull this stuff.
---

diff --git a/.github/configs b/.github/configs
index bcb67365a..51b5b1e13 100755
--- a/.github/configs
+++ b/.github/configs
@@ -136,6 +136,12 @@ case "$config" in
 	;;
     tcmalloc)
 	CONFIGFLAGS="--with-ldflags=-ltcmalloc"
+	# tcmalloc may, depending on the stacktrace generator it uses, create
+	# pipe(2) fds during shared library initialisation. These will later
+	# get clobbered by ssh/sshd calling closefrom() and chaos will ensue.
+	# Tell tcmalloc to use an unwinder that doesn't pull this stuff.
+	TCMALLOC_STACKTRACE_METHOD=generic_fp
+	export TCMALLOC_STACKTRACE_METHOD
 	;;
     krb5|heimdal)
 	CONFIGFLAGS="--with-kerberos5"