From: Benjamin Kaduk Date: Tue, 6 Jul 2021 14:49:39 +0000 (-0700) Subject: Fix comment for test_negotiated_group() test order X-Git-Tag: openssl-3.0.0-beta2~101 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3bd5319b5d0df9ecf05c8baba2c401ad8e3ba130;p=thirdparty%2Fopenssl.git Fix comment for test_negotiated_group() test order Because of how the 'client_multi' variable is set, we end up running the tests where the client configures multiple groups (and the server only configures one) before the ones where the server configures multiple groups (and the client only configures one). Reviewed-by: Matt Caswell Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/16007) --- diff --git a/test/sslapitest.c b/test/sslapitest.c index 1b3db55d6bc..49f7ef639df 100644 --- a/test/sslapitest.c +++ b/test/sslapitest.c @@ -4751,14 +4751,14 @@ static int set_ssl_groups(SSL *serverssl, SSL *clientssl, int clientmulti, * was offered in the resumption ClientHello. * * Using E for the number of EC groups and F for the number of FF groups: - * E tests of ECDHE with TLS 1.3, client sends only one group - * F tests of FFDHE with TLS 1.3, client sends only one group - * E tests of ECDHE with TLS 1.2, client sends only one group - * F tests of FFDHE with TLS 1.2, client sends only one group * E tests of ECDHE with TLS 1.3, server only has one group * F tests of FFDHE with TLS 1.3, server only has one group * E tests of ECDHE with TLS 1.2, server only has one group * F tests of FFDHE with TLS 1.2, server only has one group + * E tests of ECDHE with TLS 1.3, client sends only one group + * F tests of FFDHE with TLS 1.3, client sends only one group + * E tests of ECDHE with TLS 1.2, client sends only one group + * F tests of FFDHE with TLS 1.2, client sends only one group */ static int test_negotiated_group(int idx) {