From: bbaetz%acm.org <>
Date: Sat, 28 Jun 2003 07:14:56 +0000 (+0000)
Subject: Bug 193575 - Internal server error from votes.cgi
X-Git-Tag: bugzilla-2.17.5~129
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3bdb6be579bd5f3a98282014b0033b12a172de22;p=thirdparty%2Fbugzilla.git

Bug 193575 - Internal server error from votes.cgi
patch by bugzilla@chimpychompy.org (GavinS)
r=bbaetz, a=justdave
---

diff --git a/votes.cgi b/votes.cgi
index 1c7bc78166..dfa55b91d6 100755
--- a/votes.cgi
+++ b/votes.cgi
@@ -135,7 +135,8 @@ sub show_user {
     # special error handling should go away.
     $who || ThrowUserError("invalid_username", {name => $name});
     
-    my $canedit = 1 if ($name eq Bugzilla->user->login);
+    my $canedit = 1 if (Bugzilla->user &&
+                        $name eq Bugzilla->user->login);
     
     SendSQL("LOCK TABLES bugs READ, products READ, votes WRITE,
              cc READ, bug_group_map READ, user_group_map READ,
@@ -200,6 +201,10 @@ sub show_user {
                            opened => IsOpenedState($status) });
         }
         
+        # In case we didn't populate this earlier (i.e. an error, or
+        # a not logged in user viewing a users votes)
+        $maxvotesperbug{$product} ||= 0;
+
         $onevoteonly = 1 if (min($::prodmaxvotes{$product},
                                  $maxvotesperbug{$product}) == 1);