From: Ralph Boehme <slow@samba.org>
Date: Mon, 22 May 2023 10:25:04 +0000 (+0200)
Subject: vfs_fruit: just log failing AppleDouble conversion
X-Git-Tag: talloc-2.4.1~558
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3bf97f19c36d26b4178f7cb6202bbdd44de0c1aa;p=thirdparty%2Fsamba.git

vfs_fruit: just log failing AppleDouble conversion

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15378

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/modules/vfs_fruit.c b/source3/modules/vfs_fruit.c
index 11542d0721b..7ee6b4d9dd1 100644
--- a/source3/modules/vfs_fruit.c
+++ b/source3/modules/vfs_fruit.c
@@ -4305,8 +4305,8 @@ static NTSTATUS fruit_create_file(vfs_handle_struct *handle,
 				 macos_string_replace_map,
 				 conv_flags);
 		if (ret != 0) {
-			DBG_ERR("ad_convert() failed\n");
-			return NT_STATUS_UNSUCCESSFUL;
+			DBG_ERR("ad_convert(\"%s\") failed\n",
+				smb_fname_str_dbg(smb_fname));
 		}
 	}
 
@@ -4416,8 +4416,8 @@ static NTSTATUS fruit_freaddir_attr(struct vfs_handle_struct *handle,
 			 macos_string_replace_map,
 			 conv_flags);
 	if (ret != 0) {
-		DBG_ERR("ad_convert() failed\n");
-		return NT_STATUS_UNSUCCESSFUL;
+		DBG_ERR("ad_convert(\"%s\") failed\n",
+			fsp_str_dbg(fsp));
 	}
 
 	*pattr_data = talloc_zero(mem_ctx, struct readdir_attr_data);