From: David Lawrence <dkl@mozilla.com>
Date: Thu, 11 Dec 2014 15:15:10 +0000 (+0000)
Subject: Bug 1082106 - avoid problem where ->bz_add_columns creates a foreign key constraint... 
X-Git-Tag: bugzilla-4.2.12~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3c0c6a5b72e342e79b99fc2f33b4b14dd3a3caec;p=thirdparty%2Fbugzilla.git

Bug 1082106 - avoid problem where ->bz_add_columns creates a foreign key constraint causing failure in checksetup.pl when it tries to re-add it later. r,a=glob
---

diff --git a/Bugzilla/DB.pm b/Bugzilla/DB.pm
index 1f9c31518a..f4581ff43f 100644
--- a/Bugzilla/DB.pm
+++ b/Bugzilla/DB.pm
@@ -598,8 +598,11 @@ sub bz_add_column {
     my $current_def = $self->bz_column_info($table, $name);
 
     if (!$current_def) {
+        # REFERENCES need to happen later and not be created right away
+        my $trimmed_def = dclone($new_def);
+        delete $trimmed_def->{REFERENCES};
         my @statements = $self->_bz_real_schema->get_add_column_ddl(
-            $table, $name, $new_def, 
+            $table, $name, $trimmed_def,
             defined $init_value ? $self->quote($init_value) : undef);
         print get_text('install_column_add',
                        { column => $name, table => $table }) . "\n"
@@ -613,14 +616,14 @@ sub bz_add_column {
         # column exists there and has a REFERENCES item.
         # bz_setup_foreign_keys will then add this FK at the end of
         # Install::DB.
-        my $col_abstract = 
+        my $col_abstract =
             $self->_bz_schema->get_column_abstract($table, $name);
         if (exists $col_abstract->{REFERENCES}) {
             my $new_fk = dclone($col_abstract->{REFERENCES});
             $new_fk->{created} = 0;
             $new_def->{REFERENCES} = $new_fk;
         }
-        
+
         $self->_bz_real_schema->set_column($table, $name, $new_def);
         $self->_bz_store_real_schema;
     }