From: Jouni Malinen <j@w1.fi>
Date: Sat, 21 Nov 2009 20:00:33 +0000 (+0200)
Subject: WPS: Do not try to send byebye advertisements if socket is not valid
X-Git-Tag: hostap_0_7_0~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3c2166d63c3f8db9699bd29b152121ca63c70415;p=thirdparty%2Fhostap.git

WPS: Do not try to send byebye advertisements if socket is not valid

If initialization fails, we could potentially try to sendto() on -1
socket which would fail. No point in doing that, so just return early
from the function.
---

diff --git a/src/wps/wps_upnp_ssdp.c b/src/wps/wps_upnp_ssdp.c
index 93706ea47..d48bfdb2f 100644
--- a/src/wps/wps_upnp_ssdp.c
+++ b/src/wps/wps_upnp_ssdp.c
@@ -239,7 +239,7 @@ void advertisement_state_machine_stop(struct upnp_wps_device_sm *sm,
 	struct sockaddr_in dest;
 
 	eloop_cancel_timeout(advertisement_state_machine_handler, NULL, sm);
-	if (!send_byebye)
+	if (!send_byebye || sm->multicast_sd < 0)
 		return;
 
 	a->type = ADVERTISE_DOWN;