From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Tue, 1 Nov 2016 02:16:28 +0000 (-0400)
Subject: Cleanup the socket properly on error
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3c2755d45cae27627dd7ea0fd2039c404738bbee;p=thirdparty%2Ffreeradius-server.git

Cleanup the socket properly on error
---

diff --git a/src/modules/rlm_sigtran/libosmo-m3ua/sctp_m3ua_client.c b/src/modules/rlm_sigtran/libosmo-m3ua/sctp_m3ua_client.c
index 5f961a39e1f..3503cae484f 100644
--- a/src/modules/rlm_sigtran/libosmo-m3ua/sctp_m3ua_client.c
+++ b/src/modules/rlm_sigtran/libosmo-m3ua/sctp_m3ua_client.c
@@ -331,8 +331,7 @@ static int m3ua_sctp_assoc_complete(struct osmo_fd *ofd, unsigned int what)
 
 	if (err != 0) {
 		LOGP(DINP, LOGL_ERROR, "SCTP association failed: %s (%i).\n", strerror(err), errno);
-		fail_link(link);
-		return -1;
+		goto error;
 	}
 
 	LOGP(DINP, LOGL_NOTICE, "SCTP association established\n");