From: Victor Stinner <vstinner@python.org>
Date: Fri, 13 Mar 2026 18:44:51 +0000 (+0100)
Subject: gh-129813: Document that PyBytesWriter_GetData() cannot fail (#145900)
X-Git-Tag: v3.15.0a8~320
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3c38feb2a21aacdb009eea8baa2a6a3daf4b4932;p=thirdparty%2FPython%2Fcpython.git

gh-129813: Document that PyBytesWriter_GetData() cannot fail (#145900)

Document that PyBytesWriter_GetData() and PyBytesWriter_GetSize()
getter functions cannot fail
---

diff --git a/Doc/c-api/bytes.rst b/Doc/c-api/bytes.rst
index 82c255736837..b3cd26a85047 100644
--- a/Doc/c-api/bytes.rst
+++ b/Doc/c-api/bytes.rst
@@ -371,6 +371,8 @@ Getters
 
    Get the writer size.
 
+   The function cannot fail.
+
 .. c:function:: void* PyBytesWriter_GetData(PyBytesWriter *writer)
 
    Get the writer data: start of the internal buffer.
@@ -378,6 +380,8 @@ Getters
    The pointer is valid until :c:func:`PyBytesWriter_Finish` or
    :c:func:`PyBytesWriter_Discard` is called on *writer*.
 
+   The function cannot fail.
+
 
 Low-level API
 ^^^^^^^^^^^^^
diff --git a/Modules/binascii.c b/Modules/binascii.c
index 3f3695d50f27..c076b12fb149 100644
--- a/Modules/binascii.c
+++ b/Modules/binascii.c
@@ -923,9 +923,6 @@ binascii_a2b_ascii85_impl(PyObject *module, Py_buffer *data, int foldspaces,
         return NULL;
     }
     unsigned char *bin_data = PyBytesWriter_GetData(writer);
-    if (bin_data == NULL) {
-        goto error;
-    }
 
     uint32_t leftchar = 0;
     int group_pos = 0;