From: Douglas Bagnall Date: Fri, 20 Jan 2023 00:07:43 +0000 (+1300) Subject: s4/dns/dlz: log when falling back to obsolete dns ldb path X-Git-Tag: tevent-0.17.0~434 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3c53430eed4fb7f1b5975908495c03947065749b;p=thirdparty%2Fsamba.git s4/dns/dlz: log when falling back to obsolete dns ldb path Prior to 4.8 or so, the dlz dns files were kept in samba/private, but sharing those files is a bit less than private so a new bind-dns directory was added. As part of that patch set efforts were made to fallback gracefully to the old locations. But now that silent grace is causing confusion; the time has come to fallback resentfully. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15288 Signed-off-by: Douglas Bagnall Reviewed-by: Ralph Boehme --- diff --git a/source4/dns_server/dlz_bind9.c b/source4/dns_server/dlz_bind9.c index 02de7dae796..e5c9679835e 100644 --- a/source4/dns_server/dlz_bind9.c +++ b/source4/dns_server/dlz_bind9.c @@ -727,6 +727,11 @@ _PUBLIC_ isc_result_t dlz_create(const char *dlzname, } if (!file_exist(state->options.url)) { + dlz_bind9_state->log(ISC_LOG_ERROR, + "samba_dlz: dlz_create could not find '%s'; " + "trying old location '%s/dns/sam.ldb' instead", + state->options.url, + lpcfg_private_dir(state->lp)); state->options.url = talloc_asprintf(state, "%s/dns/sam.ldb", lpcfg_private_dir(state->lp));