From: Daniel Stenberg <daniel@haxx.se>
Date: Mon, 9 Nov 2020 07:49:59 +0000 (+0100)
Subject: mqttd: fclose test file when done
X-Git-Tag: curl-7_74_0~74
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3c5c6e7477dacdd0efd76d5681e813b88c506abc;p=thirdparty%2Fcurl.git

mqttd: fclose test file when done

Reported-by: Marc Hörsken
Reviewed-by: Jay Satiro
Bug: #6058
Closes #6189
---

diff --git a/tests/server/mqttd.c b/tests/server/mqttd.c
index f0c768ed8c..1f4344ac0b 100644
--- a/tests/server/mqttd.c
+++ b/tests/server/mqttd.c
@@ -486,6 +486,7 @@ static curl_socket_t mqttit(curl_socket_t fd)
   size_t bytes = 0; /* remaining length field size in bytes */
   char client_id[MAX_CLIENT_ID_LENGTH];
   long testno;
+  FILE *stream = NULL;
 
   static const char protocol[7] = {
     0x00, 0x04,       /* protocol length */
@@ -550,7 +551,6 @@ static curl_socket_t mqttit(curl_socket_t fd)
       }
     }
     else if(byte == MQTT_MSG_SUBSCRIBE) {
-      FILE *stream;
       int error;
       char *data;
       size_t datalen;
@@ -636,7 +636,10 @@ static curl_socket_t mqttit(curl_socket_t fd)
   } while(1);
 
   end:
-  fclose(dump);
+  if(dump)
+    fclose(dump);
+  if(stream)
+    fclose(stream);
   return CURL_SOCKET_BAD;
 }