From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Tue, 25 Jan 2022 17:15:16 +0000 (+0100)
Subject: lib: connection - Improve "wrong socket type" error message
X-Git-Tag: 2.4.0~4443
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3c6d03938f5cd910d18bb4e0545dc42bb91558b8;p=thirdparty%2Fdovecot%2Fcore.git

lib: connection - Improve "wrong socket type" error message

Especially "Connected to wrong socket type" was confusing when it was logged
for incoming connections.
---

diff --git a/src/lib/connection.c b/src/lib/connection.c
index e540f61871..342605cc1f 100644
--- a/src/lib/connection.c
+++ b/src/lib/connection.c
@@ -120,8 +120,8 @@ int connection_verify_version(struct connection *conn,
 	i_assert(!conn->version_received);
 
 	if (strcmp(service_name, conn->list->set.service_name_in) != 0) {
-		e_error(conn->event, "Connected to wrong socket type. "
-			"We want '%s', but received '%s'",
+		e_error(conn->event, "Received wrong socket type. "
+			"We want '%s', but received '%s' (wrong socket path?)",
 			conn->list->set.service_name_in, service_name);
 		return -1;
 	}