From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Sun, 19 Mar 2017 13:34:20 +0000 (+0200)
Subject: imap: Remove imapc-specific "is connection valid?" code
X-Git-Tag: 2.3.0.rc1~1863
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3c902023723d178357b83d21cd03d418bc88482c;p=thirdparty%2Fdovecot%2Fcore.git

imap: Remove imapc-specific "is connection valid?" code

This is now done by imapc itself in the previous patch
---

diff --git a/src/imap/main.c b/src/imap/main.c
index 1edca743fa..dea9ef3af7 100644
--- a/src/imap/main.c
+++ b/src/imap/main.c
@@ -220,34 +220,16 @@ int client_create_from_input(const struct mail_storage_service_input *input,
 {
 	struct mail_storage_service_user *user;
 	struct mail_user *mail_user;
-	struct mail_namespace *ns;
 	struct client *client;
 	struct imap_settings *imap_set;
 	struct lda_settings *lda_set;
 	const char *errstr;
-	enum mail_error mail_error;
 
 	if (mail_storage_service_lookup_next(storage_service, input,
 					     &user, &mail_user, error_r) <= 0)
 		return -1;
 	restrict_access_allow_coredumps(TRUE);
 
-	/* this is mainly for imapc: make sure we can do at least minimal
-	   access to the mailbox list or fail immediately. otherwise the IMAP
-	   client could be trying a lot of commands and we'd return failures
-	   for all of them. FIXME: There should be a bit less kludgy way to
-	   check this, but I'm not sure if it's worth the trouble just for
-	   imapc. */
-	ns = mail_namespace_find_inbox(mail_user->namespaces);
-	(void)mailbox_list_get_hierarchy_sep(ns->list);
-	errstr = mailbox_list_get_last_internal_error(ns->list, &mail_error);
-	if (mail_error != MAIL_ERROR_NONE) {
-		*error_r = t_strdup(errstr);
-		mail_user_unref(&mail_user);
-		mail_storage_service_user_unref(&user);
-		return -1;
-	}
-
 	imap_set = mail_storage_service_user_get_set(user)[1];
 	if (imap_set->verbose_proctitle)
 		verbose_proctitle = TRUE;