From: Ukn Unknown <4031821+uknunknown@users.noreply.github.com>
Date: Tue, 11 Nov 2025 03:06:45 +0000 (-0800)
Subject: remove ENABLE_FFMPEG4_TRANSCODING
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3c980407bbb501b2eb36de1bc0f5c790de77f5b3;p=thirdparty%2Ftvheadend.git

remove ENABLE_FFMPEG4_TRANSCODING

- remove ENABLE_FFMPEG4_TRANSCODING
---

diff --git a/src/libav.h b/src/libav.h
index 902b305d8..c73b61089 100644
--- a/src/libav.h
+++ b/src/libav.h
@@ -54,13 +54,6 @@ This list must be updated every time we use a new AV_CODEC_ID
 #define AV_CODEC_ID_DVB_TELETEXT CODEC_ID_DVB_TELETEXT
 #endif
 
-// Enable new transcoding starting ffmpeg 4
-#if LIBAVCODEC_VERSION_MAJOR < 58
-#define ENABLE_FFMPEG4_TRANSCODING 0
-#else
-#define ENABLE_FFMPEG4_TRANSCODING 1
-#endif
-
 enum AVCodecID streaming_component_type2codec_id(streaming_component_type_t type);
 streaming_component_type_t codec_id2streaming_component_type(enum AVCodecID id);
 void libav_set_loglevel(void);
diff --git a/src/transcoding/transcode/hwaccels/hwaccels.c b/src/transcoding/transcode/hwaccels/hwaccels.c
index 55b772ccb..99eeabc92 100644
--- a/src/transcoding/transcode/hwaccels/hwaccels.c
+++ b/src/transcoding/transcode/hwaccels/hwaccels.c
@@ -213,7 +213,6 @@ hwaccels_get_sharpness_filter(AVCodecContext *avctx, int value, char *filter, si
 
 /* encoding ================================================================= */
 
-#if ENABLE_FFMPEG4_TRANSCODING
 int
 hwaccels_initialize_encoder_from_decoder(const AVCodecContext *iavctx, AVCodecContext *oavctx)
 {
@@ -233,23 +232,15 @@ hwaccels_initialize_encoder_from_decoder(const AVCodecContext *iavctx, AVCodecCo
     }
     return 0;
 }
-#endif
+
 
 int
-#if ENABLE_FFMPEG4_TRANSCODING
 hwaccels_encode_setup_context(AVCodecContext *avctx)
-#else
-hwaccels_encode_setup_context(AVCodecContext *avctx, int low_power)
-#endif
 {
     switch (avctx->pix_fmt) {
 #if ENABLE_VAAPI
         case AV_PIX_FMT_VAAPI:
-#if ENABLE_FFMPEG4_TRANSCODING
             return vaapi_encode_setup_context(avctx);
-#else
-            return vaapi_encode_setup_context(avctx, low_power);
-#endif
 #endif
         default:
             break;
diff --git a/src/transcoding/transcode/hwaccels/hwaccels.h b/src/transcoding/transcode/hwaccels/hwaccels.h
index ed04f6748..4313f8b3b 100644
--- a/src/transcoding/transcode/hwaccels/hwaccels.h
+++ b/src/transcoding/transcode/hwaccels/hwaccels.h
@@ -51,17 +51,11 @@ hwaccels_get_sharpness_filter(AVCodecContext *avctx, int value, char *filter, si
 
 
 /* encoding ================================================================= */
-#if ENABLE_FFMPEG4_TRANSCODING
 int
 hwaccels_initialize_encoder_from_decoder(const AVCodecContext *iavctx, AVCodecContext *oavctx);
-#endif
 
 int
-#if ENABLE_FFMPEG4_TRANSCODING
 hwaccels_encode_setup_context(AVCodecContext *avctx);
-#else
-hwaccels_encode_setup_context(AVCodecContext *avctx, int low_power);
-#endif
 
 void
 hwaccels_encode_close_context(AVCodecContext *avctx);
diff --git a/src/transcoding/transcode/hwaccels/vaapi.c b/src/transcoding/transcode/hwaccels/vaapi.c
index 6f447c469..1e69604c7 100644
--- a/src/transcoding/transcode/hwaccels/vaapi.c
+++ b/src/transcoding/transcode/hwaccels/vaapi.c
@@ -27,101 +27,18 @@
 
 #include <va/va.h>
 
-#if ENABLE_FFMPEG4_TRANSCODING
-typedef struct tvh_vaapi_context_t {
-    int width;
-    int height;
-    AVBufferRef *hw_device_ref;
-} TVHVAContext;
-
-
-static void
-tvhva_done()
-{
-    /* nothing to do */
-}
-
-
-/* TVHVAContext ============================================================= */
-
-static void
-tvhva_context_destroy(TVHVAContext *self)
-{
-    if (self) {
-        if (self->hw_device_ref) {
-            av_buffer_unref(&self->hw_device_ref);
-        }
-        free(self);
-        self = NULL;
-    }
-}
-#else
-typedef struct tvh_vaapi_device {
-    char *hw_device_name;
-    AVBufferRef *hw_device_ref;
-    LIST_ENTRY(tvh_vaapi_device) link;
-} TVHVADevice;
-
 
 typedef struct tvh_vaapi_context_t {
-    void *display;
-    uint32_t config_id;
-    uint32_t context_id;
-    const char *logpref;
-    VAEntrypoint entrypoint;
-    enum AVPixelFormat io_format;
-    enum AVPixelFormat sw_format;
     int width;
     int height;
     AVBufferRef *hw_device_ref;
-    AVBufferRef *hw_frames_ref;
 } TVHVAContext;
 
 
-static LIST_HEAD(, tvh_vaapi_device) tvhva_devices;
-
-
-static AVBufferRef *
-tvhva_init(const char *device)
-{
-    TVHVADevice *vad;
-
-    if (tvh_str_default(device, NULL) == NULL)
-        device = "/dev/dri/renderD128";
-    LIST_FOREACH(vad, &tvhva_devices, link) {
-        if (strcmp(vad->hw_device_name, device) == 0)
-            break;
-    }
-    if (vad == NULL) {
-        vad = calloc(1, sizeof(*vad));
-        vad->hw_device_name = strdup(device);
-        LIST_INSERT_HEAD(&tvhva_devices, vad, link);
-    }
-    if (vad->hw_device_ref)
-        return vad->hw_device_ref;
-    tvhtrace_transcode(LST_VAAPI, "trying device: %s", device);
-    if (av_hwdevice_ctx_create(&vad->hw_device_ref, AV_HWDEVICE_TYPE_VAAPI,
-                               device, NULL, 0)) {
-        tvherror_transcode(LST_VAAPI,
-                 "failed to create a context for device: %s", device);
-        return NULL;
-    }
-    tvhtrace_transcode(LST_VAAPI, "successful context creation for device: %s", device);
-    return vad->hw_device_ref;
-}
-
-
 static void
 tvhva_done()
 {
-    TVHVADevice *vad;
-    
-    while ((vad = LIST_FIRST(&tvhva_devices)) != NULL) {
-        LIST_REMOVE(vad, link);
-        av_buffer_unref(&vad->hw_device_ref);
-        free(vad->hw_device_name);
-        free(vad);
-    }
+    /* nothing to do */
 }
 
 
@@ -131,22 +48,8 @@ static void
 tvhva_context_destroy(TVHVAContext *self)
 {
     if (self) {
-        if (self->context_id != VA_INVALID_ID) {
-            vaDestroyContext(self->display, self->context_id);
-            self->context_id = VA_INVALID_ID;
-        }
-        if (self->config_id != VA_INVALID_ID) {
-            vaDestroyConfig(self->display, self->config_id);
-            self->config_id = VA_INVALID_ID;
-        }
-        self->display = NULL;
-        if (self->hw_frames_ref) {
-            av_buffer_unref(&self->hw_frames_ref);
-            self->hw_frames_ref = NULL;
-        }
         if (self->hw_device_ref) {
             av_buffer_unref(&self->hw_device_ref);
-            self->hw_device_ref = NULL;
         }
         free(self);
         self = NULL;
@@ -154,452 +57,6 @@ tvhva_context_destroy(TVHVAContext *self)
 }
 
 
-static VADisplay *
-tvhva_context_display(TVHVAContext *self, AVCodecContext *avctx)
-{
-    TVHContext *ctx = avctx->opaque;
-    AVHWDeviceContext *hw_device_ctx = NULL;
-
-    if (!ctx->hw_device_ref &&
-        !(ctx->hw_device_ref = tvhva_init(ctx->hw_accel_device))) {
-        return NULL;
-    }
-    if (!(self->hw_device_ref = av_buffer_ref(ctx->hw_device_ref))) {
-        return NULL;
-    }
-    hw_device_ctx = (AVHWDeviceContext*)self->hw_device_ref->data;
-    return ((AVVAAPIDeviceContext *)hw_device_ctx->hwctx)->display;
-}
-
-
-static VAProfile
-tvhva_context_profile(TVHVAContext *self, AVCodecContext *avctx)
-{
-    VAStatus va_res = VA_STATUS_ERROR_UNKNOWN;
-    VAProfile profile = VAProfileNone, check = VAProfileNone, *profiles = NULL;
-    int i, j, profiles_max, profiles_len;
-
-    switch (avctx->codec->id) {
-        case AV_CODEC_ID_MPEG2VIDEO:
-            switch (avctx->profile) {
-                case FF_AV_PROFILE_UNKNOWN:
-                case FF_AV_PROFILE_MPEG2_MAIN:
-                    check = VAProfileMPEG2Main;
-                    break;
-                case FF_AV_PROFILE_MPEG2_SIMPLE:
-                    check = VAProfileMPEG2Simple;
-                    break;
-                default:
-                    break;
-            }
-            break;
-        case AV_CODEC_ID_H264:
-            switch (avctx->profile) {
-                case FF_AV_PROFILE_UNKNOWN:
-                case FF_AV_PROFILE_H264_HIGH:
-                    check = VAProfileH264High;
-                    break;
-                case FF_AV_PROFILE_H264_CONSTRAINED_BASELINE:
-                    check = VAProfileH264ConstrainedBaseline;
-                    break;
-                case FF_AV_PROFILE_H264_MAIN:
-                    check = VAProfileH264Main;
-                    break;
-                default:
-                    break;
-            }
-            break;
-        case AV_CODEC_ID_HEVC:
-            switch (avctx->profile) {
-                case FF_AV_PROFILE_UNKNOWN:
-                case FF_AV_PROFILE_HEVC_MAIN:
-                    check = VAProfileHEVCMain;
-                    break;
-                case FF_AV_PROFILE_HEVC_MAIN_10:
-                case FF_AV_PROFILE_HEVC_REXT:
-                    check = VAProfileHEVCMain10;
-                    break;
-                default:
-                    break;
-            }
-            break;
-        case AV_CODEC_ID_VP8:
-            switch (avctx->profile) {
-                case FF_AV_PROFILE_UNKNOWN:
-                    check = VAProfileVP8Version0_3;
-                    break;
-                default:
-                    break;
-            }
-            break;
-        case AV_CODEC_ID_VP9:
-            switch (avctx->profile) {
-                case FF_AV_PROFILE_UNKNOWN:
-                case FF_AV_PROFILE_VP9_0:
-                    check = VAProfileVP9Profile0;
-                    break;
-                case FF_AV_PROFILE_VP9_1:
-                    check = VAProfileVP9Profile1;
-                    break;
-                case FF_AV_PROFILE_VP9_2:
-                    check = VAProfileVP9Profile2;
-                    break;
-                case FF_AV_PROFILE_VP9_3:
-                    check = VAProfileVP9Profile3;
-                    break;
-                default:
-                    break;
-            }
-            break;
-        default:
-            break;
-    }
-
-    if (check != VAProfileNone &&
-        (profiles_max = vaMaxNumProfiles(self->display)) > 0 &&
-        (profiles = calloc(profiles_max, sizeof(VAProfile)))) {
-        for (j = 0; j < profiles_max; j++) {
-            profiles[j] = VAProfileNone;
-        }
-        if (profiles_max == 0) {
-            tvherror_transcode(LST_VAAPI, "%s: vaMaxNumProfiles() returned %d; vaapi doesn't have any profiles available, run: $ vainfo", self->logpref, profiles_max);
-        }
-        va_res = vaQueryConfigProfiles(self->display,
-                                       profiles, &profiles_len);
-        if (va_res == VA_STATUS_SUCCESS) {
-            for (i = 0; i < profiles_len; i++) {
-                if (profiles[i] == check) {
-                    profile = check;
-                    break;
-                }
-            }
-        }
-        else {
-            tvherror_transcode(LST_VAAPI, "%s: va_res != VA_STATUS_SUCCESS; Failed to query profiles: %d (%s), run: $ vainfo", self->logpref, va_res, vaErrorStr(va_res));
-        }
-        free(profiles);
-    }
-
-    return profile;
-}
-
-
-static int
-tvhva_context_check_profile(TVHVAContext *self, VAProfile profile)
-{
-    VAStatus va_res = VA_STATUS_ERROR_UNKNOWN;
-    VAEntrypoint *entrypoints = NULL;
-    int res = -1, i, entrypoints_max, entrypoints_len;
-
-    entrypoints_max = vaMaxNumEntrypoints(self->display);
-
-    if (entrypoints_max > 0) {
-        entrypoints = calloc(entrypoints_max, sizeof(VAEntrypoint));
-        va_res = vaQueryConfigEntrypoints(self->display, profile, entrypoints, &entrypoints_len);
-        if (va_res == VA_STATUS_SUCCESS) {
-            for (i = 0; i < entrypoints_len; i++) {
-                if (entrypoints[i] == self->entrypoint) {
-                    res = 0;
-                    break;
-                }
-            }
-        }
-        else {
-            tvherror_transcode(LST_VAAPI, "%s: va_res != VA_STATUS_SUCCESS; Failed to query entrypoints: %d (%s), run: $ vainfo", self->logpref, va_res, vaErrorStr(va_res));
-        }
-        if (res != 0) {
-            // before giving up we swap VAEntrypointEncSliceLP with VAEntrypointEncSlice or viceversa
-            if (self->entrypoint == VAEntrypointEncSlice) {
-                // we try VAEntrypointEncSliceLP
-                self->entrypoint = VAEntrypointEncSliceLP;
-                va_res = vaQueryConfigEntrypoints(self->display, profile, entrypoints, &entrypoints_len);
-                if (va_res == VA_STATUS_SUCCESS) {
-                    for (i = 0; i < entrypoints_len; i++) {
-                        if (entrypoints[i] == self->entrypoint) {
-                            res = 0;
-                            break;
-                        }
-                    }
-                }
-            }
-            else {
-                // we try VAEntrypointEncSlice
-                self->entrypoint = VAEntrypointEncSlice;
-                va_res = vaQueryConfigEntrypoints(self->display, profile, entrypoints, &entrypoints_len);
-                if (va_res == VA_STATUS_SUCCESS) {
-                    for (i = 0; i < entrypoints_len; i++) {
-                        if (entrypoints[i] == self->entrypoint) {
-                            res = 0;
-                            break;
-                        }
-                    }
-                }
-            }
-        }
-        free(entrypoints);
-    }
-    else {
-        tvherror_transcode(LST_VAAPI, "%s: vaMaxNumEntrypoints() returned %d; vaapi doesn't have any entrypoints available, run: $ vainfo", self->logpref, entrypoints_max);
-    }
-    return res;
-}
-
-
-static unsigned int
-tvhva_get_format(enum AVPixelFormat pix_fmt)
-{
-    switch (pix_fmt) {
-        //case AV_PIX_FMT_YUV420P: // the cake is a lie
-        case AV_PIX_FMT_NV12:
-            return VA_RT_FORMAT_YUV420;
-        case AV_PIX_FMT_YUV422P:
-        case AV_PIX_FMT_UYVY422:
-        case AV_PIX_FMT_YUYV422:
-            return VA_RT_FORMAT_YUV422;
-        case AV_PIX_FMT_GRAY8:
-            return VA_RT_FORMAT_YUV400;
-        default:
-            return 0;
-    }
-}
-
-
-static int
-tvhva_context_config(TVHVAContext *self, VAProfile profile, unsigned int format)
-{
-    VAStatus va_res = VA_STATUS_ERROR_UNKNOWN;
-    VAConfigAttrib attrib = { VAConfigAttribRTFormat, VA_ATTRIB_NOT_SUPPORTED };
-
-    // vaCreateConfig
-    va_res = vaGetConfigAttributes(self->display, profile, self->entrypoint,
-                                   &attrib, 1);
-    if (va_res != VA_STATUS_SUCCESS) {
-        tvherror_transcode(LST_VAAPI, "%s: vaGetConfigAttributes: %s",
-                 self->logpref, vaErrorStr(va_res));
-        return -1;
-    }
-    if (attrib.value == VA_ATTRIB_NOT_SUPPORTED || !(attrib.value & format)) {
-        tvherror_transcode(LST_VAAPI, "%s: unsupported VA_RT_FORMAT", self->logpref);
-        return -1;
-    }
-    attrib.value = format;
-    va_res = vaCreateConfig(self->display, profile, self->entrypoint,
-                            &attrib, 1, &self->config_id);
-    if (va_res != VA_STATUS_SUCCESS) {
-        tvherror_transcode(LST_VAAPI, "%s: vaCreateConfig: %s",
-                 self->logpref, vaErrorStr(va_res));
-        return -1;
-    }
-    return 0;
-}
-
-
-static int
-tvhva_context_check_constraints(TVHVAContext *self)
-{
-    AVVAAPIHWConfig *va_config = NULL;
-    AVHWFramesConstraints *hw_constraints = NULL;
-    enum AVPixelFormat sw_format = AV_PIX_FMT_NONE;
-    const AVPixFmtDescriptor *sw_desc = NULL, *io_desc = NULL;
-    int i, ret = 0;
-
-    if (!(va_config = av_hwdevice_hwconfig_alloc(self->hw_device_ref))) {
-        tvherror_transcode(LST_VAAPI, "%s: failed to allocate hwconfig", self->logpref);
-        return AVERROR(ENOMEM);
-    }
-    va_config->config_id = self->config_id;
-
-    hw_constraints =
-        av_hwdevice_get_hwframe_constraints(self->hw_device_ref, va_config);
-    if (!hw_constraints) {
-        tvherror_transcode(LST_VAAPI, "%s: failed to get constraints", self->logpref);
-        av_freep(&va_config);
-        return -1;
-    }
-
-    if (self->io_format != AV_PIX_FMT_NONE) {
-        for (i = 0; hw_constraints->valid_sw_formats[i] != AV_PIX_FMT_NONE; i++) {
-            sw_format = hw_constraints->valid_sw_formats[i];
-            if (sw_format == self->io_format) {
-                self->sw_format = sw_format;
-                break;
-            }
-        }
-        if (self->sw_format == AV_PIX_FMT_NONE &&
-            (io_desc = av_pix_fmt_desc_get(self->io_format))) {
-            for (i = 0; hw_constraints->valid_sw_formats[i] != AV_PIX_FMT_NONE; i++) {
-                sw_format = hw_constraints->valid_sw_formats[i];
-                if ((sw_desc = av_pix_fmt_desc_get(sw_format)) &&
-                    sw_desc->nb_components == io_desc->nb_components &&
-                    sw_desc->log2_chroma_w == io_desc->log2_chroma_w &&
-                    sw_desc->log2_chroma_h == io_desc->log2_chroma_h) {
-                    self->sw_format = sw_format;
-                    break;
-                }
-            }
-        }
-    }
-    if (self->sw_format == AV_PIX_FMT_NONE) {
-        tvherror_transcode(LST_VAAPI, "%s: VAAPI hardware does not support pixel format: %s",
-                 self->logpref, av_get_pix_fmt_name(self->io_format));
-        ret = AVERROR(EINVAL);
-        goto end;
-    }
-
-    // Ensure the picture size is supported by the hardware.
-    if (self->width < hw_constraints->min_width ||
-        self->height < hw_constraints->min_height ||
-        self->width > hw_constraints->max_width ||
-        self->height > hw_constraints->max_height) {
-        tvherror_transcode(LST_VAAPI, "%s: VAAPI hardware does not support image "
-                 "size %dx%d (constraints: width %d-%d height %d-%d).",
-                 self->logpref, self->width, self->height,
-                 hw_constraints->min_width, hw_constraints->max_width,
-                 hw_constraints->min_height, hw_constraints->max_height);
-        ret = AVERROR(EINVAL);
-    }
-
-end:
-    av_hwframe_constraints_free(&hw_constraints);
-    av_freep(&va_config);
-    return ret;
-}
-
-
-static int
-tvhva_context_setup(TVHVAContext *self, AVCodecContext *avctx)
-{
-    VAProfile profile = VAProfileNone;
-    unsigned int format = 0;
-    VAStatus va_res = VA_STATUS_ERROR_UNKNOWN;
-    AVHWFramesContext *hw_frames_ctx = NULL;
-    AVVAAPIFramesContext *va_frames = NULL;
-
-    if (!(self->display = tvhva_context_display(self, avctx))) {
-        return -1;
-    }
-
-    libav_vaapi_init_context(self->display);
-    // 
-    profile = tvhva_context_profile(self, avctx);
-
-    if (profile == VAProfileNone) {
-        tvherror_transcode(LST_VAAPI, "%s: tvhva_context_profile() returned VAProfileNone for %s",
-                 self->logpref,
-                 avctx->codec->name);
-        return -1;
-    }
-
-    if (tvhva_context_check_profile(self, profile)) {
-        tvherror_transcode(LST_VAAPI, "%s: tvhva_context_check_profile() check failed for codec: %s --> codec not available",
-                 self->logpref,
-                 avctx->codec->name);
-        return -1;
-    }
-    if (!(format = tvhva_get_format(self->io_format))) {
-        tvherror_transcode(LST_VAAPI, "%s: unsupported pixel format: %s",
-                 self->logpref,
-                 av_get_pix_fmt_name(self->io_format));
-        return -1;
-    }
-
-    if (tvhva_context_config(self, profile, format) ||
-        tvhva_context_check_constraints(self)) {
-        return -1;
-    }
-
-    if (!(self->hw_frames_ref = av_hwframe_ctx_alloc(self->hw_device_ref))) {
-        tvherror_transcode(LST_VAAPI, "%s: failed to create VAAPI frame context.",
-                 self->logpref);
-        return AVERROR(ENOMEM);
-    }
-    hw_frames_ctx = (AVHWFramesContext*)self->hw_frames_ref->data;
-    hw_frames_ctx->format = AV_PIX_FMT_VAAPI;
-    hw_frames_ctx->sw_format = self->sw_format;
-    hw_frames_ctx->width = self->width;
-    hw_frames_ctx->height = self->height;
-    hw_frames_ctx->initial_pool_size = 32;
-
-    if (av_hwframe_ctx_init(self->hw_frames_ref) < 0) {
-        tvherror_transcode(LST_VAAPI, "%s: failed to initialise VAAPI frame context",
-                 self->logpref);
-        return -1;
-    }
-
-    // vaCreateContext
-    if (self->entrypoint == VAEntrypointVLD) { // decode only
-        va_frames = hw_frames_ctx->hwctx;
-        va_res = vaCreateContext(self->display, self->config_id,
-                                 self->width, self->height,
-                                 VA_PROGRESSIVE,
-                                 va_frames->surface_ids, va_frames->nb_surfaces,
-                                 &self->context_id);
-        if (va_res != VA_STATUS_SUCCESS) {
-            tvherror_transcode(LST_VAAPI, "%s: vaCreateContext: %s",
-                     self->logpref, vaErrorStr(va_res));
-            return -1;
-        }
-    }
-
-    if (!(avctx->hw_frames_ctx = av_buffer_ref(self->hw_frames_ref))) {
-        return AVERROR(ENOMEM);
-    }
-
-    avctx->sw_pix_fmt = self->sw_format;
-    avctx->thread_count = 1;
-
-    return 0;
-}
-
-
-static TVHVAContext *
-tvhva_context_create(const char *logpref,
-                     AVCodecContext *avctx, VAEntrypoint entrypoint)
-{
-    TVHVAContext *self = NULL;
-    enum AVPixelFormat pix_fmt;
-
-    if (!(self = calloc(1, sizeof(TVHVAContext)))) {
-        tvherror_transcode(LST_VAAPI, "%s: failed to allocate vaapi context", logpref);
-        return NULL;
-    }
-    self->logpref = logpref;
-    self->display = NULL;
-    self->config_id = VA_INVALID_ID;
-    self->context_id = VA_INVALID_ID;
-    self->entrypoint = entrypoint;
-    pix_fmt = self->entrypoint == VAEntrypointVLD ?
-                        avctx->sw_pix_fmt : avctx->pix_fmt;
-    if (pix_fmt == AV_PIX_FMT_YUV420P ||
-        pix_fmt == AV_PIX_FMT_VAAPI) {
-        self->io_format = AV_PIX_FMT_NV12;
-    }
-    else {
-        self->io_format = pix_fmt;
-    }
-    if (self->io_format == AV_PIX_FMT_NONE) {
-        tvherror_transcode(LST_VAAPI, "%s: failed to get pix_fmt for vaapi context "
-                           "(sw_pix_fmt: %s, pix_fmt: %s)",
-                           logpref,
-                           av_get_pix_fmt_name(avctx->sw_pix_fmt),
-                           av_get_pix_fmt_name(avctx->pix_fmt));
-        free(self);
-        return NULL;
-    }
-    self->sw_format = AV_PIX_FMT_NONE;
-    self->width = avctx->coded_width;
-    self->height = avctx->coded_height;
-    self->hw_device_ref = NULL;
-    self->hw_frames_ref = NULL;
-    if (tvhva_context_setup(self, avctx)) {
-        tvhva_context_destroy(self);
-        return NULL;
-    }
-    return self;
-}
-#endif
-
-
 /* decoding ================================================================= */
 
 static int
@@ -617,7 +74,6 @@ vaapi_decode_setup_context(AVCodecContext *avctx)
 {
     TVHContext *ctx = avctx->opaque;
 
-#if ENABLE_FFMPEG4_TRANSCODING
     TVHVAContext *self = NULL;
     int ret = -1;
 
@@ -651,18 +107,6 @@ vaapi_decode_setup_context(AVCodecContext *avctx)
     ctx->hw_accel_ictx = self;
     avctx->get_buffer2 = vaapi_get_buffer2;
     avctx->pix_fmt = AV_PIX_FMT_VAAPI;
-#else
-    if (!(ctx->hw_accel_ictx =
-          tvhva_context_create("decode", avctx, VAEntrypointVLD))) {
-        return -1;
-    }
-
-    avctx->get_buffer2 = vaapi_get_buffer2;
-#if LIBAVCODEC_VERSION_MAJOR < 60
-    avctx->thread_safe_callbacks = 0;
-#endif
-#endif 
-
     return 0;
 }
 
@@ -672,11 +116,10 @@ vaapi_decode_close_context(AVCodecContext *avctx)
 {
     TVHContext *ctx = avctx->opaque;
 
-#if ENABLE_FFMPEG4_TRANSCODING
+
     if (avctx->hw_device_ctx) {
         av_buffer_unref(&avctx->hw_device_ctx);
     }
-#endif
     tvhva_context_destroy(ctx->hw_accel_ictx);
 }
 
@@ -727,7 +170,6 @@ vaapi_get_sharpness_filter(AVCodecContext *avctx, int value, char *filter, size_
 
 /* encoding ================================================================= */
 
-#if ENABLE_FFMPEG4_TRANSCODING
 // lifted from ffmpeg-6.1.1/doc/examples/vaapi_encode.c line 41
 static int set_hwframe_ctx(AVCodecContext *ctx, AVBufferRef *hw_device_ctx)
 {
@@ -760,10 +202,9 @@ static int set_hwframe_ctx(AVCodecContext *ctx, AVBufferRef *hw_device_ctx)
     av_buffer_unref(&hw_frames_ref);
     return err;
 }
-#endif
+
 
 int
-#if ENABLE_FFMPEG4_TRANSCODING
 vaapi_encode_setup_context(AVCodecContext *avctx)
 {
     TVHContext *ctx = avctx->opaque;
@@ -785,33 +226,6 @@ vaapi_encode_setup_context(AVCodecContext *avctx)
     }
     return ret;
 }
-#else
-vaapi_encode_setup_context(AVCodecContext *avctx, int low_power)
-{
-    TVHContext *ctx = avctx->opaque;
-    TVHVAContext *hwaccel_context = NULL;
-    VAEntrypoint entrypoint;
-
-    if (low_power) {
-        entrypoint = VAEntrypointEncSliceLP;
-    }
-    else {
-        entrypoint = VAEntrypointEncSlice;
-    }
-
-    if (!(hwaccel_context =
-          tvhva_context_create("encode", avctx, entrypoint))) {
-        return -1;
-    }
-    if (!(ctx->hw_device_octx = av_buffer_ref(hwaccel_context->hw_device_ref))) {
-        tvhva_context_destroy(hwaccel_context);
-        return AVERROR(ENOMEM);
-    }
-    tvhva_context_destroy(hwaccel_context);
-
-    return 0;
-}
-#endif
 
 
 void
@@ -822,7 +236,6 @@ vaapi_encode_close_context(AVCodecContext *avctx)
     if (ctx->hw_device_octx) {
         av_buffer_unref(&ctx->hw_device_octx);
     }
-#if ENABLE_FFMPEG4_TRANSCODING
     // avctx->hw_device_ctx is cleaned up only if ffmpeg exit with error and didn't perform the clean up
     if (avctx->hw_device_ctx) {
         av_buffer_unref(&avctx->hw_device_ctx);
@@ -830,7 +243,6 @@ vaapi_encode_close_context(AVCodecContext *avctx)
     if (avctx->hw_frames_ctx) {
         av_buffer_unref(&avctx->hw_frames_ctx);
     }
-#endif
 }
 
 
diff --git a/src/transcoding/transcode/hwaccels/vaapi.h b/src/transcoding/transcode/hwaccels/vaapi.h
index 57417b052..c4e14bc5a 100644
--- a/src/transcoding/transcode/hwaccels/vaapi.h
+++ b/src/transcoding/transcode/hwaccels/vaapi.h
@@ -51,11 +51,7 @@ vaapi_get_sharpness_filter(AVCodecContext *avctx, int value, char *filter, size_
 /* encoding ================================================================= */
 
 int
-#if ENABLE_FFMPEG4_TRANSCODING
 vaapi_encode_setup_context(AVCodecContext *avctx);
-#else
-vaapi_encode_setup_context(AVCodecContext *avctx, int low_power);
-#endif
 
 void
 vaapi_encode_close_context(AVCodecContext *avctx);
diff --git a/src/transcoding/transcode/video.c b/src/transcoding/transcode/video.c
index 484d52c57..eb6605cf8 100644
--- a/src/transcoding/transcode/video.c
+++ b/src/transcoding/transcode/video.c
@@ -233,7 +233,6 @@ tvh_video_context_open_encoder(TVHContext *self, AVDictionary **opts)
     }
 
 #if ENABLE_HWACCELS
-#if ENABLE_FFMPEG4_TRANSCODING
     // hwaccel is the user input for Hardware acceleration from Codec parameteres
     int hwaccel = -1;
     if ((hwaccel = tvh_codec_profile_video_get_hwaccel(self->profile)) < 0) {
@@ -258,11 +257,6 @@ tvh_video_context_open_encoder(TVHContext *self, AVDictionary **opts)
             }
         }
     }
-#else
-    if (hwaccels_encode_setup_context(self->oavctx, self->profile->low_power)) {
-        return -1;
-    }
-#endif // from ENABLE_FFMPEG4_TRANSCODING
 #endif // from ENABLE_HWACCELS
 
     // XXX: is this a safe assumption?