From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 11 Nov 2020 17:58:54 +0000 (-0500)
Subject: return "true", not pointer.  CID 1469178
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3ca0ab3cbca75355a0fd4df39de2162ba7d4c0ee;p=thirdparty%2Ffreeradius-server.git

return "true", not pointer.  CID 1469178
---

diff --git a/src/modules/rlm_csv/rlm_csv.c b/src/modules/rlm_csv/rlm_csv.c
index f9a839491cf..c49fe726b76 100644
--- a/src/modules/rlm_csv/rlm_csv.c
+++ b/src/modules/rlm_csv/rlm_csv.c
@@ -189,6 +189,8 @@ static bool insert_entry(CONF_SECTION *conf, rlm_csv_t *inst, rlm_csv_entry_t *e
 {
 	rlm_csv_entry_t *old;
 
+	fr_assert(e != NULL);
+
 	old = find_entry(inst, e->key);
 	if (old) {
 		if (!inst->allow_multiple_keys && !inst->multiple_index_fields) {
@@ -202,7 +204,7 @@ static bool insert_entry(CONF_SECTION *conf, rlm_csv_t *inst, rlm_csv_entry_t *e
 		 */
 		while (old->next) old = old->next;
 		old->next = e;
-		return e;
+		return true;
 	}
 
 	if ((inst->key_data_type == FR_TYPE_IPV4_ADDR) || (inst->key_data_type == FR_TYPE_IPV4_PREFIX)) {