From: W.C.A. Wijngaards <wouter@nlnetlabs.nl>
Date: Thu, 6 Jun 2024 07:30:09 +0000 (+0200)
Subject: - Fix memory leak in setup of dsa sig.
X-Git-Tag: release-1.21.0rc1~61
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3cad5818a1b894415c3cd85987320e79717cf5c0;p=thirdparty%2Funbound.git

- Fix memory leak in setup of dsa sig.
---

diff --git a/doc/Changelog b/doc/Changelog
index 6838029e3..4c4310418 100644
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,3 +1,6 @@
+6 June 2024: Wouter
+	- Fix memory leak in setup of dsa sig.
+
 4 June 2024: Yorgos
 	- Merge #1080: AddressSanitizer detection in tdir tests and memory leak
 	  fixes.
diff --git a/validator/val_secalgo.c b/validator/val_secalgo.c
index 786516749..40ebb1728 100644
--- a/validator/val_secalgo.c
+++ b/validator/val_secalgo.c
@@ -423,7 +423,10 @@ setup_dsa_sig(unsigned char** sig, unsigned int* len)
 	if(!dsasig) return 0;
 
 #ifdef HAVE_DSA_SIG_SET0
-	if(!DSA_SIG_set0(dsasig, R, S)) return 0;
+	if(!DSA_SIG_set0(dsasig, R, S)) {
+		DSA_SIG_free(dsasig);
+		return 0;
+	}
 #else
 #  ifndef S_SPLINT_S
 	dsasig->r = R;