From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Fri, 2 Dec 2022 12:53:59 +0000 (+0200)
Subject: lmtp: Fix memory leak by unreferencing duplicated settings parser
X-Git-Tag: 2.4.0~3315
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3cb91e1c071666aa8dc3f4a1a07f41829bad0bbf;p=thirdparty%2Fdovecot%2Fcore.git

lmtp: Fix memory leak by unreferencing duplicated settings parser

Broken by 8807ff0df48c5a19fec2a1f01dc0dac6d864b7b2
---

diff --git a/src/lmtp/lmtp-client.c b/src/lmtp/lmtp-client.c
index ea4710a2c5..441ec44d21 100644
--- a/src/lmtp/lmtp-client.c
+++ b/src/lmtp/lmtp-client.c
@@ -123,6 +123,7 @@ static void client_read_settings(struct client *client, bool ssl)
 
 	set_parser = settings_parser_dup(set_parser, client->pool);
 	lmtp_settings_get(set_parser, client->pool, &lmtp_set, &lda_set);
+	settings_parser_unref(&set_parser);
 	const struct var_expand_table *tab =
 		mail_storage_service_get_var_expand_table(storage_service, &input);
 	if (settings_var_expand(&lmtp_setting_parser_info, lmtp_set,