From: Samuel Cabrero Date: Mon, 6 Feb 2023 18:03:03 +0000 (+0100) Subject: winbind:varlink: Implement memberships by group name X-Git-Tag: tevent-0.17.0~734 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3ce570c7b5b346476f0526d0a53016fbca27912d;p=thirdparty%2Fsamba.git winbind:varlink: Implement memberships by group name $> userdbctl -s org.samba.winbind users-in-group "AFOREST+domain users" Enabled services: org.samba.winbind USER GROUP AFOREST+administrator AFOREST+domain users AFOREST+krbtgt AFOREST+domain users AFOREST+user1 AFOREST+domain users 3 memberships listed. $> SYSTEMD_LOG_LEVEL=7 getent -sgroup:systemd group "AFOREST+domain users" varlink: Setting state idle-client /run/systemd/userdb/org.samba.winbind: Sending message: {"method":"io.systemd.UserDatabase.GetGroupRecord","parameters":{"groupName":"AFOREST+domain users","service":"org.samba.winbind"}} /run/systemd/userdb/org.samba.winbind: Changing state idle-client → awaiting-reply /run/systemd/userdb/org.samba.winbind: New incoming message: {"parameters":{"incomplete":false,"record":{"gid":20513,"groupName":"AFOREST+domain users","members":["AFOREST+administrator","AFOREST+user1","AFOREST+krbtgt"],"service":"org.samba.winbind"}}} /run/systemd/userdb/org.samba.winbind: Changing state awaiting-reply → processing-reply /run/systemd/userdb/org.samba.winbind: Changing state processing-reply → idle-client varlink: Setting state idle-client /run/systemd/userdb/org.samba.winbind: Sending message: {"method":"io.systemd.UserDatabase.GetMemberships","parameters":{"groupName":"AFOREST+domain users","service":"org.samba.winbind"},"more":true} /run/systemd/userdb/org.samba.winbind: Changing state idle-client → awaiting-reply-more /run/systemd/userdb/org.samba.winbind: New incoming message: {"continues":true,"parameters":{"groupName":"AFOREST+domain users","userName":"AFOREST+administrator"}} /run/systemd/userdb/org.samba.winbind: Changing state awaiting-reply-more → processing-reply /run/systemd/userdb/org.samba.winbind: Changing state processing-reply → awaiting-reply-more /run/systemd/userdb/org.samba.winbind: New incoming message: {"continues":true,"parameters":{"groupName":"AFOREST+domain users","userName":"AFOREST+user1"}} /run/systemd/userdb/org.samba.winbind: Changing state awaiting-reply-more → processing-reply /run/systemd/userdb/org.samba.winbind: Changing state processing-reply → awaiting-reply-more /run/systemd/userdb/org.samba.winbind: New incoming message: {"parameters":{"groupName":"AFOREST+domain users","userName":"AFOREST+krbtgt"}} /run/systemd/userdb/org.samba.winbind: Changing state awaiting-reply-more → processing-reply /run/systemd/userdb/org.samba.winbind: Changing state processing-reply → idle-client AFOREST+domain users:x:20513:AFOREST+administrator,AFOREST+user1,AFOREST+krbtgt Signed-off-by: Samuel Cabrero Reviewed-by: Andreas Schneider --- diff --git a/source3/winbindd/winbindd_varlink.c b/source3/winbindd/winbindd_varlink.c index fe613329d53..e17427e7d4d 100644 --- a/source3/winbindd/winbindd_varlink.c +++ b/source3/winbindd/winbindd_varlink.c @@ -408,6 +408,14 @@ static long io_systemd_getmemberships(VarlinkService *service, flags, parm_service, parm_username); + } else if (parm_username == NULL && parm_groupname != NULL) { + /* List group members */ + status = wb_vl_memberships_by_group(state, + state->ev_ctx, + call, + flags, + parm_service, + parm_groupname); } if (NT_STATUS_IS_ERR(status)) { diff --git a/source3/winbindd/winbindd_varlink.h b/source3/winbindd/winbindd_varlink.h index 87903002770..497542a5f11 100644 --- a/source3/winbindd/winbindd_varlink.h +++ b/source3/winbindd/winbindd_varlink.h @@ -105,6 +105,12 @@ NTSTATUS wb_vl_memberships_by_user(TALLOC_CTX *mem_ctx, uint64_t flags, const char *service, const char *user_name); +NTSTATUS wb_vl_memberships_by_group(TALLOC_CTX *mem_ctx, + struct tevent_context *ev_ctx, + VarlinkCall *call, + uint64_t flags, + const char *service, + const char *group_name); bool winbind_setup_varlink(TALLOC_CTX *mem_ctx, struct tevent_context *ev_ctx); diff --git a/source3/winbindd/winbindd_varlink_getmemberships.c b/source3/winbindd/winbindd_varlink_getmemberships.c index 46d79a11f22..2351f8a1c4f 100644 --- a/source3/winbindd/winbindd_varlink_getmemberships.c +++ b/source3/winbindd/winbindd_varlink_getmemberships.c @@ -629,3 +629,159 @@ fail: TALLOC_FREE(s); return status; } + +/****************************************************************************** + * Memberships by group name + *****************************************************************************/ + +struct memberships_by_group_state { + struct tevent_context *ev_ctx; + struct winbindd_request *fake_req; + struct winbindd_cli_state *fake_cli; + const char *groupname; + VarlinkCall *call; +}; + +static int +memberships_by_group_state_destructor(struct memberships_by_group_state *s) +{ + if (s->call != NULL) { + s->call = varlink_call_unref(s->call); + } + + return 0; +} + +static void memberships_by_group_getgrnam_done(struct tevent_req *req) +{ + struct memberships_by_group_state *s = + tevent_req_callback_data(req, + struct memberships_by_group_state); + struct winbindd_response *response = NULL; + struct winbindd_gr *gr = NULL; + char *gr_members = NULL; + NTSTATUS status; + + /* winbindd_*_recv functions expect a talloc-allocated response */ + response = talloc_zero(s, struct winbindd_response); + if (response == NULL) { + DBG_ERR("No memory\n"); + varlink_call_reply_error( + s->call, + WB_VL_REPLY_ERROR_SERVICE_NOT_AVAILABLE, + NULL); + goto out; + } + + status = winbindd_getgrnam_recv(req, response); + TALLOC_FREE(req); + + if (NT_STATUS_EQUAL(status, NT_STATUS_NONE_MAPPED)) { + varlink_call_reply_error(s->call, + WB_VL_REPLY_ERROR_NO_RECORD_FOUND, + NULL); + goto out; + } else if (NT_STATUS_IS_ERR(status)) { + DBG_ERR("winbindd_getgrnam failed: %s\n", nt_errstr(status)); + varlink_call_reply_error( + s->call, + WB_VL_REPLY_ERROR_SERVICE_NOT_AVAILABLE, + NULL); + goto out; + } + + gr = &response->data.gr; + gr_members = (char *)response->extra_data.data; + + if (gr->num_gr_mem == 0 || gr_members == NULL) { + varlink_call_reply_error(s->call, + WB_VL_REPLY_ERROR_NO_RECORD_FOUND, + NULL); + goto out; + } + + member_list_reply(s->call, gr, gr_members, false); +out: + TALLOC_FREE(s); +} + +NTSTATUS wb_vl_memberships_by_group(TALLOC_CTX *mem_ctx, + struct tevent_context *ev_ctx, + VarlinkCall *call, + uint64_t flags, + const char *service, + const char *group_name) +{ + struct memberships_by_group_state *s = NULL; + struct tevent_req *req = NULL; + NTSTATUS status; + + /* Check if group expansion is enabled */ + if (!lp_winbind_expand_groups()) { + varlink_call_reply_error( + call, + WB_VL_REPLY_ERROR_ENUMERATION_NOT_SUPPORTED, + NULL); + return NT_STATUS_OK; + } + + /* Check more flag is set */ + if (!(flags & VARLINK_CALL_MORE)) { + DBG_WARNING("Request without more flag set\n"); + return NT_STATUS_INVALID_PARAMETER; + } + + s = talloc_zero(mem_ctx, struct memberships_by_group_state); + if (s == NULL) { + DBG_ERR("No memory\n"); + return NT_STATUS_NO_MEMORY; + } + talloc_set_destructor(s, memberships_by_group_state_destructor); + + s->fake_cli = talloc_zero(s, struct winbindd_cli_state); + if (s->fake_cli == NULL) { + DBG_ERR("No memory\n"); + status = NT_STATUS_NO_MEMORY; + goto fail; + } + + s->fake_req = talloc_zero(s, struct winbindd_request); + if (s->fake_req == NULL) { + DBG_ERR("No memory\n"); + status = NT_STATUS_NO_MEMORY; + goto fail; + } + + s->groupname = talloc_strdup(s, group_name); + if (s->groupname == NULL) { + DBG_ERR("No memory\n"); + status = NT_STATUS_NO_MEMORY; + goto fail; + } + + s->ev_ctx = ev_ctx; + s->call = varlink_call_ref(call); + + status = wb_vl_fake_cli_state(call, service, s->fake_cli); + if (NT_STATUS_IS_ERR(status)) { + DBG_ERR("Failed to create fake winbindd_cli_state: %s\n", + nt_errstr(status)); + goto fail; + } + + s->fake_req->cmd = WINBINDD_GETGRNAM; + fstrcpy(s->fake_req->data.username, group_name); + + req = winbindd_getgrnam_send(s, s->ev_ctx, s->fake_cli, s->fake_req); + if (req == NULL) { + DBG_ERR("No memory\n"); + status = NT_STATUS_NO_MEMORY; + goto fail; + } + tevent_req_set_callback(req, memberships_by_group_getgrnam_done, s); + + return NT_STATUS_OK; +fail: + TALLOC_FREE(s); + return status; +}