From: Willy Tarreau <w@1wt.eu>
Date: Thu, 14 Oct 2021 09:39:18 +0000 (+0200)
Subject: MINOR: proto_tcp: also report the attempted MSS values in error message
X-Git-Tag: v2.5-dev10~43
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3cf05cb0b16055c3c9258750803bac7c45ba229b;p=thirdparty%2Fhaproxy.git

MINOR: proto_tcp: also report the attempted MSS values in error message

The MSS errors are the only ones not indicating what was attempted, let's
report the value that was tried, as it can help users spot them in the
config (particularly if a default value was used).
---

diff --git a/src/proto_tcp.c b/src/proto_tcp.c
index 0ffe56c64b..95466538b2 100644
--- a/src/proto_tcp.c
+++ b/src/proto_tcp.c
@@ -621,7 +621,7 @@ int tcp_bind_listener(struct listener *listener, char *errmsg, int errlen)
 	if (listener->maxseg > 0) {
 		if (setsockopt(fd, IPPROTO_TCP, TCP_MAXSEG,
 			       &listener->maxseg, sizeof(listener->maxseg)) == -1) {
-			chunk_appendf(msg, "%scannot set MSS", msg->data ? ", " : "");
+			chunk_appendf(msg, "%scannot set MSS to %d", msg->data ? ", " : "", listener->maxseg);
 			err |= ERR_WARN;
 		}
 	} else {
@@ -639,7 +639,7 @@ int tcp_bind_listener(struct listener *listener, char *errmsg, int errlen)
 		if (defaultmss > 0 &&
 		    tmpmaxseg != defaultmss &&
 		    setsockopt(fd, IPPROTO_TCP, TCP_MAXSEG, &defaultmss, sizeof(defaultmss)) == -1) {
-			chunk_appendf(msg, "%scannot set MSS", msg->data ? ", " : "");
+			chunk_appendf(msg, "%scannot set MSS to %d", msg->data ? ", " : "", defaultmss);
 			err |= ERR_WARN;
 		}
 	}