From: Peter Krempa <pkrempa@redhat.com>
Date: Wed, 14 May 2025 15:53:13 +0000 (+0200)
Subject: qemuBackupPrepare: Actually allow 'VIR_STORAGE_NET_HOST_TRANS_FD'
X-Git-Tag: v11.4.0-rc1~39
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3d05fe7aa31e58ec8a7286ccc9524638a7741326;p=thirdparty%2Flibvirt.git

qemuBackupPrepare: Actually allow 'VIR_STORAGE_NET_HOST_TRANS_FD'

While I've actually implemented support for FD passing the NBD server
socket in eb768a556db I managed to misplace the hunk allowing the 'FD'
transport in the validation code, rendering the whole feature useless.

Fix the validation logic to make the feature usable.

Fixes: eb768a556db75040f7b518d198a18bd0f5d6faad
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c
index f6ee31dc2a..fb3558d280 100644
--- a/src/qemu/qemu_backup.c
+++ b/src/qemu/qemu_backup.c
@@ -86,8 +86,10 @@ qemuBackupPrepare(virDomainBackupDef *def)
             /* TODO: Do we need to mess with selinux? */
             break;
 
-        case VIR_STORAGE_NET_HOST_TRANS_RDMA:
         case VIR_STORAGE_NET_HOST_TRANS_FD:
+            break;
+
+        case VIR_STORAGE_NET_HOST_TRANS_RDMA:
         case VIR_STORAGE_NET_HOST_TRANS_LAST:
             virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                            _("unexpected transport in <domainbackup>"));