From: David Vossel <dvossel@digium.com>
Date: Fri, 8 May 2009 14:51:09 +0000 (+0000)
Subject: "misdn show config" segfaults asterisk, if no MSN lists
X-Git-Tag: 1.4.25-rc1~13
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3d0faa34ca0c652a6021e8dd2fa0d5d2666b235a;p=thirdparty%2Fasterisk.git

"misdn show config" segfaults asterisk, if no MSN lists

(closes issue #14976)
Reported by: alecdavis
Patches:
      misdn_config.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis, FabienToune



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@193262 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/channels/misdn_config.c b/channels/misdn_config.c
index e16b8fd85f..71f54adcc5 100644
--- a/channels/misdn_config.c
+++ b/channels/misdn_config.c
@@ -798,7 +798,9 @@ void misdn_cfg_get_config_string (int port, enum misdn_cfg_elements elem, char*
 				for (; iter; iter = iter->next) {
 					strncat(tempbuf, iter->msn, sizeof(tempbuf) - strlen(tempbuf) - 1);
 				}
-				tempbuf[strlen(tempbuf)-2] = 0;
+				if (strlen(tempbuf) > 1) {
+					tempbuf[strlen(tempbuf)-2] = 0;
+				}
 			}
 			snprintf(buf, bufsize, " -> msns: %s", *tempbuf ? tempbuf : "none");
 			break;