From: Victor Julien <vjulien@oisf.net>
Date: Tue, 11 Feb 2025 18:31:43 +0000 (+0100)
Subject: commandline: fix undefined behavior in parsing list-keywords
X-Git-Tag: suricata-8.0.0-beta1~453
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3d46c18474c488e642d64fb0406066ead5e240da;p=thirdparty%2Fsuricata.git

commandline: fix undefined behavior in parsing list-keywords

Flagged by clang-tidy.
---

diff --git a/src/suricata.c b/src/suricata.c
index 60b67f717b..dddc702b25 100644
--- a/src/suricata.c
+++ b/src/suricata.c
@@ -1570,7 +1570,7 @@ TmEcode SCParseCommandLine(int argc, char **argv)
                 return TM_ECODE_OK;
             } else if (strcmp((long_opts[option_index]).name, "list-keywords") == 0) {
                 if (optarg) {
-                    if (strcmp("short",optarg)) {
+                    if (strcmp("short", optarg) != 0) {
                         suri->keyword_info = optarg;
                     }
                 }