From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 2 Sep 2021 05:14:44 +0000 (+1200)
Subject: s4/dnsserver: Fix NULL check
X-Git-Tag: ldb-2.5.0~787
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3d490c225b5beff668ec8be714d1f197b794dc9b;p=thirdparty%2Fsamba.git

s4/dnsserver: Fix NULL check

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source4/dns_server/dnsserver_common.c b/source4/dns_server/dnsserver_common.c
index 984c65dbdf8..71aeee8169d 100644
--- a/source4/dns_server/dnsserver_common.c
+++ b/source4/dns_server/dnsserver_common.c
@@ -283,7 +283,7 @@ static struct ldb_parse_tree *build_equality_operation(
 	value = &el->u.equality.value;
 	length = (add_asterix) ? size + 2 : size + 1;
 	value->data = talloc_zero_array(el, uint8_t, length);
-	if (el == NULL) {
+	if (value->data == NULL) {
 		DBG_ERR("Unable to allocate value->data\n");
 		TALLOC_FREE(el);
 		return NULL;