From: Cheng-Yang Chou Date: Thu, 26 Mar 2026 01:29:03 +0000 (+0800) Subject: sched_ext: Fix missing return after scx_error() in scx_dsq_move() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3d6379196d5fc9698b683ec40ffd9452d2183c4a;p=thirdparty%2Fkernel%2Flinux.git sched_ext: Fix missing return after scx_error() in scx_dsq_move() When scx_bpf_dsq_move[_vtime]() is called on a task that belongs to a different scheduler, scx_error() is invoked to flag the violation. scx_error() schedules an asynchronous scheduler teardown via irq_work and returns immediately, so execution falls through and the DSQ move proceeds on a cross-scheduler task regardless, potentially corrupting DSQ state. Add the missing return false so the function exits right after reporting the error, consistent with the other early-exit checks in the same function (e.g. scx_vet_enq_flags() failure at the top). Fixes: bb4d9fd55158 ("sched_ext: scx_dsq_move() should validate the task belongs to the right scheduler") Signed-off-by: Cheng-Yang Chou Signed-off-by: Tejun Heo --- diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c index 551bfb99157d1..a5d8871ac8651 100644 --- a/kernel/sched/ext.c +++ b/kernel/sched/ext.c @@ -8094,6 +8094,7 @@ static bool scx_dsq_move(struct bpf_iter_scx_dsq_kern *kit, if (unlikely(!scx_task_on_sched(sch, p))) { scx_error(sch, "scx_bpf_dsq_move[_vtime]() on %s[%d] but the task belongs to a different scheduler", p->comm, p->pid); + return false; } /*