From: VMware, Inc <>
Date: Wed, 18 Sep 2013 03:25:21 +0000 (-0700)
Subject: Fix VMHSUtilFileMove and clarify comments of File_Replace
X-Git-Tag: 2013.09.16-1328054~72
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3d814b1c8ea9b6c5249c064e47326f37026ff2d6;p=thirdparty%2Fopen-vm-tools.git

Fix VMHSUtilFileMove and clarify comments of File_Replace

VMHSUtilFileMove has been broken since 2008 and no one has noticed,
so I would be happy to remove the entire mv command from VMHS if
no one would miss it.

Signed-off-by: Dmitry Torokhov <dtor@vmware.com>
---

diff --git a/open-vm-tools/lib/file/filePosix.c b/open-vm-tools/lib/file/filePosix.c
index 4eea362c4..a46a5b74c 100644
--- a/open-vm-tools/lib/file/filePosix.c
+++ b/open-vm-tools/lib/file/filePosix.c
@@ -2338,8 +2338,8 @@ File_IsSameFile(ConstUnicode path1,  // IN:
  *
  * File_Replace --
  *
- *      Replace old file with new file, and attempt to reproduce
- *      file permissions.  A NULL value for either the oldName or
+ *      Replace old file (destination) with new file (source), and attempt to
+ *      reproduce file permissions.  A NULL value for either the oldName or
  *      newName will result in failure and errno will be set to EFAULT.
  *
  * Results: