From: Peter Krempa <pkrempa@redhat.com>
Date: Fri, 16 Sep 2022 16:18:47 +0000 (+0200)
Subject: virDomainNetDefParseXML: Don't overload 'node' variable when parsing <coalesce>
X-Git-Tag: v8.9.0-rc1~150
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3d81ed1448ef859030d1bbeac14c83e68437e221;p=thirdparty%2Flibvirt.git

virDomainNetDefParseXML: Don't overload 'node' variable when parsing <coalesce>

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 72089194af..4b0a76e360 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -8994,6 +8994,7 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt,
     xmlNodePtr bandwidth_node = NULL;
     xmlNodePtr mac_node = NULL;
     xmlNodePtr target_node = NULL;
+    xmlNodePtr coalesce_node = NULL;
     VIR_XPATH_NODE_AUTORESTORE(ctxt)
     int rv;
     g_autofree char *macaddr = NULL;
@@ -9410,9 +9411,8 @@ virDomainNetDefParseXML(virDomainXMLOption *xmlopt,
         return NULL;
     }
 
-    node = virXPathNode("./coalesce", ctxt);
-    if (node) {
-        if (virDomainNetDefCoalesceParseXML(node, ctxt, &def->coalesce) < 0)
+    if ((coalesce_node = virXPathNode("./coalesce", ctxt))) {
+        if (virDomainNetDefCoalesceParseXML(coalesce_node, ctxt, &def->coalesce) < 0)
             return NULL;
     }