From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Thu, 27 Nov 2025 23:45:44 +0000 (+0100)
Subject: submission-login: submission-proxy - Fix assert calls in submission_proxy_parse_line()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3dde534cb70e017e99f040ad055a538d327223f9;p=thirdparty%2Fdovecot%2Fcore.git

submission-login: submission-proxy - Fix assert calls in submission_proxy_parse_line()
---

diff --git a/src/submission-login/submission-proxy.c b/src/submission-login/submission-proxy.c
index a23a8c02b5..c239040b6c 100644
--- a/src/submission-login/submission-proxy.c
+++ b/src/submission-login/submission-proxy.c
@@ -489,18 +489,20 @@ submission_proxy_handle_redirect(struct client *client, unsigned int status,
 
 int submission_proxy_parse_line(struct client *client, const char *line)
 {
+	i_assert(!client->destroyed);
+
 	struct submission_client *subm_client =
 		container_of(client, struct submission_client, common);
 	struct smtp_server_cmd_ctx *cmd = subm_client->auth_cmd;
+
+	i_assert(cmd != NULL);
+
 	struct smtp_server_command *command = cmd->cmd;
 	struct ostream *output;
 	bool last_line = FALSE, invalid_line = FALSE;
 	const char *suffix, *text = NULL, *enh_code = NULL;
 	unsigned int status = 0;
 
-	i_assert(!client->destroyed);
-	i_assert(cmd != NULL);
-
 	if ((line[3] != ' ' && line[3] != '-') ||
 	    str_parse_uint(line, &status, &text) < 0 ||
 	    status < 200 || status >= 560) {