From: Mark Michelson <mmichelson@digium.com>
Date: Fri, 18 May 2012 17:47:31 +0000 (+0000)
Subject: Address MISSING_BREAK static analysis reports some more.
X-Git-Tag: 1.8.14.0-rc1~3^2~26
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3ddfb50fe4dc4c5e894666df5652647ac802bc7e;p=thirdparty%2Fasterisk.git

Address MISSING_BREAK static analysis reports some more.

This addresses core findings 4 and 6.

Moises Silva helped me by stating that a break could be
safely added to the case where it is added in chan_dahdi.c

In say.c, I have added a comment indicating that static analysis
complains but that it is currently unknown if this is correct.

This fixes all core findings of this type.

(closes issue ASTERISK-19662)
reported by Matthew Jordan




git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@367027 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/channels/chan_dahdi.c b/channels/chan_dahdi.c
index 329d3b9c1a..f3a293397e 100644
--- a/channels/chan_dahdi.c
+++ b/channels/chan_dahdi.c
@@ -7966,6 +7966,7 @@ static struct ast_frame *dahdi_handle_event(struct ast_channel *ast)
 #else
 		ast_log(LOG_WARNING, "Received bits changed on %s signalling?\n", sig2str(p->sig));
 #endif
+		break;
 	case DAHDI_EVENT_PULSE_START:
 		/* Stop tone if there's a pulse start and the PBX isn't started */
 		if (!ast->pbx)
diff --git a/main/say.c b/main/say.c
index e522528748..e1580a3c11 100644
--- a/main/say.c
+++ b/main/say.c
@@ -6113,6 +6113,9 @@ int ast_say_date_with_format_zh(struct ast_channel *chan, time_t t, const char *
 				if (tm.tm_hour < 10) {
 					res = wait_file(chan, ints, "digits/0", lang);
 				}
+				/* XXX Static analysis warns of no break here. No idea if this is
+				 * correct or not
+				 */
 			case 'k':
 				/* 24-Hour */
 				if (!(tm.tm_hour % 10) || tm.tm_hour < 10) {