From: Colin Ian King <colin.king@canonical.com>
Date: Fri, 11 Aug 2017 18:33:04 +0000 (+0100)
Subject: Bluetooth: kfree tmp rather than an alias to it
X-Git-Tag: v4.14-rc1~130^2~211^2~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3dfe55d9cae7413c1bd12cbc0f9145384f753014;p=thirdparty%2Fkernel%2Flinux.git

Bluetooth: kfree tmp rather than an alias to it

While the kfree of dhkey_a is of the same address of tmp, it
probably is clearer and more human readable if tmp is kfree'd
rather than dhkey_a.

Detected by CoverityScan, CID#1448650 ("Free of address-of expression")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---

diff --git a/net/bluetooth/selftest.c b/net/bluetooth/selftest.c
index ee92c925ecc5d..34a1227f43910 100644
--- a/net/bluetooth/selftest.c
+++ b/net/bluetooth/selftest.c
@@ -164,7 +164,7 @@ static int __init test_ecdh_sample(const u8 priv_a[32], const u8 priv_b[32],
 		ret = -EINVAL;
 
 out:
-	kfree(dhkey_a);
+	kfree(tmp);
 	return ret;
 }