From: x2018 <xkernel.wang@foxmail.com>
Date: Wed, 24 Nov 2021 03:26:09 +0000 (+0800)
Subject: check the return value of OPENSSL_strdup(CRYPTO_strdup) in apps/lib/app_rand.c:32
X-Git-Tag: openssl-3.2.0-alpha1~3283
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3e0441520b9a349dc50662919ea18f03dfc0d624;p=thirdparty%2Fopenssl.git

check the return value of OPENSSL_strdup(CRYPTO_strdup) in apps/lib/app_rand.c:32

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/17124)
---

diff --git a/apps/lib/app_rand.c b/apps/lib/app_rand.c
index 1e10044accd..ad93858bfdb 100644
--- a/apps/lib/app_rand.c
+++ b/apps/lib/app_rand.c
@@ -28,8 +28,14 @@ void app_RAND_load_conf(CONF *c, const char *section)
         BIO_printf(bio_err, "Can't load %s into RNG\n", randfile);
         ERR_print_errors(bio_err);
     }
-    if (save_rand_file == NULL)
+    if (save_rand_file == NULL) {
         save_rand_file = OPENSSL_strdup(randfile);
+        /* If some internal memory errors have occurred */
+        if (save_rand_file == NULL) {
+            BIO_printf(bio_err, "Can't duplicate %s\n", randfile);
+            ERR_print_errors(bio_err);
+        }
+    }
 }
 
 static int loadfiles(char *name)