From: Mark Michelson <mmichelson@digium.com>
Date: Mon, 23 Mar 2009 17:59:28 +0000 (+0000)
Subject: Fix a memory leak in res_monitor.c
X-Git-Tag: 1.4.25-rc1~110
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3e474b3b75ea1a99c6d80c6c3678006a70c934ab;p=thirdparty%2Fasterisk.git

Fix a memory leak in res_monitor.c

The only way that this leak would occur is if Monitor were started
using the Manager interface and no File: header were given. Discovered
while reviewing the ast_channel_ao2 review request.



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@183700 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/res/res_monitor.c b/res/res_monitor.c
index 4baa1580de..69db65cd20 100644
--- a/res/res_monitor.c
+++ b/res/res_monitor.c
@@ -520,11 +520,7 @@ static int start_monitor_action(struct mansession *s, const struct message *m)
 
 	if (ast_strlen_zero(fname)) {
 		/* No filename base specified, default to channel name as per CLI */		
-		if (!(fname = ast_strdup(c->name))) {
-			astman_send_error(s, m, "Could not start monitoring channel");
-			ast_channel_unlock(c);
-			return 0;
-		}
+		fname = ast_strdupa(c->name);
 		/* Channels have the format technology/channel_name - have to replace that /  */
 		if ((d = strchr(fname, '/'))) 
 			*d = '-';