From: Christian Brauner <brauner@kernel.org>
Date: Wed, 20 Nov 2024 08:17:25 +0000 (+0100)
Subject: statmount: fix security option retrieval
X-Git-Tag: v6.13-rc1~60^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3e5360167ac3bccdc032cdafa68d4904a8fa0c75;p=thirdparty%2Flinux.git

statmount: fix security option retrieval

Fix the inverted check for security_sb_show_options().

Link: https://lore.kernel.org/r/c8eaa647-5d67-49b6-9401-705afcb7e4d7@stanley.mountain
Link: https://lore.kernel.org/r/20241120-verehren-rhabarber-83a11b297bcc@brauner
Fixes: aefff51e1c29 ("statmount: retrieve security mount options")
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Cc: stable@vger.kernel.org # mainline only
Signed-off-by: Christian Brauner <brauner@kernel.org>
---

diff --git a/fs/namespace.c b/fs/namespace.c
index 17563d8e382b1..23e81c2a1e3fe 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -5116,7 +5116,7 @@ static int statmount_opt_sec_array(struct kstatmount *s, struct seq_file *seq)
 	int err;
 
 	err = security_sb_show_options(seq, sb);
-	if (!err)
+	if (err)
 		return err;
 
 	err = statmount_opt_process(seq, start);