From: VMware, Inc <>
Date: Mon, 26 Apr 2010 18:15:52 +0000 (-0700)
Subject: rpctool: exit with failure if RPC command failed.
X-Git-Tag: 2010.04.25-253928~44
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3e539cd0f2fa121540b1c47addd29ed468d131d8;p=thirdparty%2Fopen-vm-tools.git

rpctool: exit with failure if RPC command failed.

Some recent change overwrote the return value of the RPC call, making
the tool return success (0) even if the RPC failed.

Signed-off-by: Marcelo Vanzin <mvanzin@vmware.com>
---

diff --git a/open-vm-tools/rpctool/rpctool.c b/open-vm-tools/rpctool/rpctool.c
index 0e113a25f..1a1ee6d8f 100644
--- a/open-vm-tools/rpctool/rpctool.c
+++ b/open-vm-tools/rpctool/rpctool.c
@@ -159,7 +159,7 @@ main(int argc, char *argv[])
    if (SetSignalHandler(ERROR_SIGNAL, SignalHandler, FALSE)) {
       ret = RpcToolCommand(argc, argv);
    }
-   ret = SetSignalHandler(ERROR_SIGNAL, NULL, TRUE) ? 0 : 1;
+   SetSignalHandler(ERROR_SIGNAL, NULL, TRUE);
 #endif
    return ret;
 }